Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2337553002: Revert of Turned on SkSL->GLSL compiler (Closed)

Created:
4 years, 3 months ago by ethannicholas
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, dogben, egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Turned on SkSL->GLSL compiler (patchset #12 id:220001 of https://codereview.chromium.org/2288033003/ ) Reason for revert: Compilation errors on some bots. Original issue's description: > Turned on SkSL->GLSL compiler > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 > > Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/a316395e66095aa1bf495525e34c991688467a45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -518 lines) Patch
M gyp/sksl.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.h View 4 chunks +2 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 4 chunks +35 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 3 chunks +4 lines, -91 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLShaderVar.h View 1 chunk +7 lines, -3 lines 0 comments Download
D src/sksl/README View 1 chunk +0 lines, -34 lines 0 comments Download
M src/sksl/SkSLCompiler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.h View 4 chunks +2 lines, -13 lines 0 comments Download
M src/sksl/SkSLGLSLCodeGenerator.cpp View 9 chunks +19 lines, -132 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 4 chunks +7 lines, -9 lines 0 comments Download
M src/sksl/SkSLParser.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M src/sksl/SkSLUtil.h View 1 chunk +5 lines, -9 lines 0 comments Download
M src/sksl/SkSLUtil.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M src/sksl/sksl_frag.include View 1 chunk +0 lines, -2 lines 0 comments Download
M tests/SkSLGLSLTest.cpp View 9 chunks +56 lines, -142 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ethannicholas
Created Revert of Turned on SkSL->GLSL compiler
4 years, 3 months ago (2016-09-12 16:15:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2337553002/1
4 years, 3 months ago (2016-09-12 16:15:48 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 16:15:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a316395e66095aa1bf495525e34c991688467a45

Powered by Google App Engine
This is Rietveld 408576698