Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2340383003: Revert of Enable whitelisting for targets other than libchrome. (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable whitelisting for targets other than libchrome. (patchset #8 id:40002 of https://codereview.chromium.org/2336033002/ ) Reason for revert: will update when fixed Original issue's description: > Refactor chrome resource targets into chrome_paks.gni > > This will allow monochrome to easily define its own set of the same > targets with a different resource whitelist > > BUG=641032 > > Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e > Cr-Commit-Position: refs/heads/master@{#418966} TBR=brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -257 lines) Patch
M chrome/BUILD.gn View 7 chunks +212 lines, -34 lines 0 comments Download
D chrome/chrome_paks.gni View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
agrieve
4 years, 3 months ago (2016-09-16 00:17:01 UTC) #1
Created Revert of Enable whitelisting for targets other than libchrome.

Powered by Google App Engine
This is Rietveld 408576698