|
|
Created:
4 years, 3 months ago by agrieve Modified:
4 years, 3 months ago Reviewers:
brettw CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor chrome resource targets into chrome_paks.gni
This will allow monochrome to easily define its own set of the same
targets with a different resource whitelist
BUG=641032
Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e
Cr-Commit-Position: refs/heads/master@{#418966}
Patch Set 1 #Patch Set 2 : 🎃 #Patch Set 3 : don't change output_dir #Patch Set 4 : 🍷 #Patch Set 5 : 🍹 #Patch Set 6 : 🎈 #Patch Set 7 : 🎄 #Patch Set 8 : 🎀 #
Messages
Total messages: 44 (37 generated)
Description was changed from ========== Enable whitelisting for targets other than libchrome. BUG= ========== to ========== Enable whitelisting for targets other than libchrome. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
Description was changed from ========== Enable whitelisting for targets other than libchrome. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Refactor chrome resource targets into chrome_paks.gni This will allow monochrome to easily define its own set of the same targets with a different resource whitelist BUG=641032 ==========
agrieve@chromium.org changed reviewers: + brettw@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/15 19:59:37, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run One last pak file shuffle :)
rs lgtm
The CQ bit was unchecked by agrieve@chromium.org
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Refactor chrome resource targets into chrome_paks.gni This will allow monochrome to easily define its own set of the same targets with a different resource whitelist BUG=641032 ========== to ========== Refactor chrome resource targets into chrome_paks.gni This will allow monochrome to easily define its own set of the same targets with a different resource whitelist BUG=641032 ==========
Message was sent while issue was closed.
Committed patchset #8 (id:40002)
Message was sent while issue was closed.
Description was changed from ========== Refactor chrome resource targets into chrome_paks.gni This will allow monochrome to easily define its own set of the same targets with a different resource whitelist BUG=641032 ========== to ========== Refactor chrome resource targets into chrome_paks.gni This will allow monochrome to easily define its own set of the same targets with a different resource whitelist BUG=641032 Committed: https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e Cr-Commit-Position: refs/heads/master@{#418966} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/33312c3d3dc09f27325e74644b346123b325891e Cr-Commit-Position: refs/heads/master@{#418966}
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:40002) has been created in https://codereview.chromium.org/2348643002/ by miu@chromium.org. The reason for reverting is: Broke ninja on Linux x64: ninja: Entering directory `out/Release' [1/1] Regenerating ninja files FAILED: build.ninja /mnt/ssd/miu/chromium/src/buildtools/linux64/gn --root=/mnt/ssd/miu/chromium/src -q gen //out/Release/ ERROR at //chrome/BUILD.gn:1358:5: Undefined identifier. public_deps += [ ":default_apps" ] ^---------- See //BUILD.gn:211:7: which caused the file to be included. "//chrome", ^--------- ninja: error: rebuilding 'build.ninja': subcommand failed .
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:40002) has been created in https://codereview.chromium.org/2340383003/ by agrieve@chromium.org. The reason for reverting is: will update when fixed. |