Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: net/log/net_log_util.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/log/net_log_util.cc
diff --git a/net/log/net_log_util.cc b/net/log/net_log_util.cc
index 55a98cb7037a20a120466f91f563449faf189d99..da724e9f0bbb41693e0494b2110c1a8f2347728b 100644
--- a/net/log/net_log_util.cc
+++ b/net/log/net_log_util.cc
@@ -29,7 +29,11 @@
#include "net/http/http_server_properties.h"
#include "net/http/http_transaction_factory.h"
#include "net/log/net_log.h"
+#include "net/log/net_log_capture_mode.h"
+#include "net/log/net_log_entry.h"
#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_parameters_callback.h"
+#include "net/log/net_log_with_source.h"
#include "net/proxy/proxy_config.h"
#include "net/proxy/proxy_retry_info.h"
#include "net/proxy/proxy_service.h"
@@ -519,15 +523,15 @@ NET_EXPORT void CreateNetLogEntriesForActiveObjects(
// Create fake events.
for (auto* request : requests) {
- NetLog::ParametersCallback callback =
+ NetLogParametersCallback callback =
base::Bind(&GetRequestStateAsValue, base::Unretained(request));
// Note that passing the hardcoded NetLogCaptureMode::Default() below is
// fine, since GetRequestStateAsValue() ignores the capture mode.
- NetLog::EntryData entry_data(
+ NetLogEntryData entry_data(
NetLogEventType::REQUEST_ALIVE, request->net_log().source(),
NetLogEventPhase::BEGIN, request->creation_time(), &callback);
- NetLog::Entry entry(&entry_data, NetLogCaptureMode::Default());
+ NetLogEntry entry(&entry_data, NetLogCaptureMode::Default());
observer->OnAddEntry(entry);
}
}

Powered by Google App Engine
This is Rietveld 408576698