Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Side by Side Diff: net/log/net_log_util.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)
Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/log/net_log_util.h" 5 #include "net/log/net_log_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
(...skipping 11 matching lines...) Expand all
22 #include "net/base/net_errors.h" 22 #include "net/base/net_errors.h"
23 #include "net/base/sdch_manager.h" 23 #include "net/base/sdch_manager.h"
24 #include "net/disk_cache/disk_cache.h" 24 #include "net/disk_cache/disk_cache.h"
25 #include "net/dns/host_cache.h" 25 #include "net/dns/host_cache.h"
26 #include "net/dns/host_resolver.h" 26 #include "net/dns/host_resolver.h"
27 #include "net/http/http_cache.h" 27 #include "net/http/http_cache.h"
28 #include "net/http/http_network_session.h" 28 #include "net/http/http_network_session.h"
29 #include "net/http/http_server_properties.h" 29 #include "net/http/http_server_properties.h"
30 #include "net/http/http_transaction_factory.h" 30 #include "net/http/http_transaction_factory.h"
31 #include "net/log/net_log.h" 31 #include "net/log/net_log.h"
32 #include "net/log/net_log_capture_mode.h"
33 #include "net/log/net_log_entry.h"
32 #include "net/log/net_log_event_type.h" 34 #include "net/log/net_log_event_type.h"
35 #include "net/log/net_log_parameters_callback.h"
36 #include "net/log/net_log_with_source.h"
33 #include "net/proxy/proxy_config.h" 37 #include "net/proxy/proxy_config.h"
34 #include "net/proxy/proxy_retry_info.h" 38 #include "net/proxy/proxy_retry_info.h"
35 #include "net/proxy/proxy_service.h" 39 #include "net/proxy/proxy_service.h"
36 #include "net/quic/core/quic_protocol.h" 40 #include "net/quic/core/quic_protocol.h"
37 #include "net/quic/core/quic_utils.h" 41 #include "net/quic/core/quic_utils.h"
38 #include "net/socket/ssl_client_socket.h" 42 #include "net/socket/ssl_client_socket.h"
39 #include "net/url_request/url_request.h" 43 #include "net/url_request/url_request.h"
40 #include "net/url_request/url_request_context.h" 44 #include "net/url_request/url_request_context.h"
41 45
42 namespace net { 46 namespace net {
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 for (auto* request : *context->url_requests()) { 516 for (auto* request : *context->url_requests()) {
513 requests.push_back(request); 517 requests.push_back(request);
514 } 518 }
515 } 519 }
516 520
517 // Sort by creation time. 521 // Sort by creation time.
518 std::sort(requests.begin(), requests.end(), RequestCreatedBefore); 522 std::sort(requests.begin(), requests.end(), RequestCreatedBefore);
519 523
520 // Create fake events. 524 // Create fake events.
521 for (auto* request : requests) { 525 for (auto* request : requests) {
522 NetLog::ParametersCallback callback = 526 NetLogParametersCallback callback =
523 base::Bind(&GetRequestStateAsValue, base::Unretained(request)); 527 base::Bind(&GetRequestStateAsValue, base::Unretained(request));
524 528
525 // Note that passing the hardcoded NetLogCaptureMode::Default() below is 529 // Note that passing the hardcoded NetLogCaptureMode::Default() below is
526 // fine, since GetRequestStateAsValue() ignores the capture mode. 530 // fine, since GetRequestStateAsValue() ignores the capture mode.
527 NetLog::EntryData entry_data( 531 NetLogEntryData entry_data(
528 NetLogEventType::REQUEST_ALIVE, request->net_log().source(), 532 NetLogEventType::REQUEST_ALIVE, request->net_log().source(),
529 NetLogEventPhase::BEGIN, request->creation_time(), &callback); 533 NetLogEventPhase::BEGIN, request->creation_time(), &callback);
530 NetLog::Entry entry(&entry_data, NetLogCaptureMode::Default()); 534 NetLogEntry entry(&entry_data, NetLogCaptureMode::Default());
531 observer->OnAddEntry(entry); 535 observer->OnAddEntry(entry);
532 } 536 }
533 } 537 }
534 538
535 } // namespace net 539 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698