Extracting NetLog inner classes into their own classes.

chrome/browser/extensions/api/log_private/log_private_api.h

Index: chrome/browser/extensions/api/log_private/log_private_api.h
diff --git a/chrome/browser/extensions/api/log_private/log_private_api.h b/chrome/browser/extensions/api/log_private/log_private_api.h
index 7fe0d77bd5dd70a70df6bff5845a32f7667d1305..b67ff4ae0f62714acb4806d57795cc64121084e9 100644
--- a/chrome/browser/extensions/api/log_private/log_private_api.h
+++ b/chrome/browser/extensions/api/log_private/log_private_api.h
@@ -90,7 +90,7 @@ class LogPrivateAPI : public BrowserContextKeyedAPI,
                            UnloadedExtensionInfo::Reason reason) override;
 
   // NetLog::ThreadSafeObserver implementation:
-  void OnAddEntry(const net::NetLog::Entry& entry) override;
+  void OnAddEntry(const net::NetLogEntry& entry) override;

[Devlin, 2016/10/04 15:03:06]

forward declaration needed

[mikecirone, 2016/10/04 17:38:35]

I don't think the forward is needed because the override aspect guarantees that
the class is included/forwarded from the base class's file.

I was finding this forwarding behavior in files I touched, like
fuzzed_socket_factory.h:
https://cs.chromium.org/chromium/src/net/socket/fuzzed_socket_factory.h?gsn=t...

The FuzzedSocketFactory::CreateTransportClientSocket override method has an
AddressList ref and SocketPerformanceWatcher ptr parameters. Both AddressList
and SocketPerformanceWatcher are not included/forwarded in the file, but they
are included/forwarded in the base file, client_socket_factory.h.

[Devlin, 2016/10/04 17:59:22]

Ah, missed that this was an override.  Fair enough. :)

 
   void PostPendingEntries();
   void AddEntriesOnUI(std::unique_ptr<base::ListValue> value);