net/log/net_log_util.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/net_log_util.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/net_log_util.h

diff --git a/net/log/net_log_util.h b/net/log/net_log_util.h

index e6a65e444692bbc568d7dfb4f955c1f6ee6b48e6..829dcf569a59ee8792658d30c0612d50f507d18c 100644

--- a/net/log/net_log_util.h

+++ b/net/log/net_log_util.h

@@ -45,7 +45,7 @@ NET_EXPORT std::unique_ptr<base::DictionaryValue> GetNetInfo(

int info_sources);

// Takes in a set of contexts and a NetLog::Observer, and passes in

-// NetLog::Entries to the observer for certain NetLog::Sources with pending

+// NetLog::Entries to the observer for certain NetLogSources with pending

// events. This allows requests that were ongoing when logging was started to

// have an initial event that has some information. This is particularly useful

// for hung requests. Note that these calls are not protected by the NetLog's