extensions/browser/api/display_source/display_source_apitestbase.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/display_source/display_source_apitestbase.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « extensions/browser/api/cast_channel/cast_socket_unittest.cc ('k') | extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/display_source/display_source_apitestbase.cc

diff --git a/extensions/browser/api/display_source/display_source_apitestbase.cc b/extensions/browser/api/display_source/display_source_apitestbase.cc

index b51afbc133b65303e0bdcc888ecf0067bc7fad90..5b9ac884d56bb44c600ac00c9b7a1b62a6d9677c 100644

--- a/extensions/browser/api/display_source/display_source_apitestbase.cc

+++ b/extensions/browser/api/display_source/display_source_apitestbase.cc

@@ -10,6 +10,7 @@

#include "base/memory/ptr_util.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

#include "net/udp/udp_socket.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -465,9 +466,9 @@ CheckSourceMessageContent(std::string pattern,

void MockDisplaySourceConnectionDelegate::BindToUdpSocket() {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- socket_.reset(new net::UDPSocket(

- net::DatagramSocket::DEFAULT_BIND, net::RandIntCallback(), nullptr,

- net::NetLog::Source()));

+ socket_.reset(new net::UDPSocket(net::DatagramSocket::DEFAULT_BIND,

+ net::RandIntCallback(), nullptr,

+ net::NetLogSource()));

net::IPAddress address;

ASSERT_TRUE(address.AssignFromIPLiteral(kLocalHost));