extensions/browser/api/cast_channel/cast_socket_unittest.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_socket_unittest.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_socket_unittest.cc

diff --git a/extensions/browser/api/cast_channel/cast_socket_unittest.cc b/extensions/browser/api/cast_channel/cast_socket_unittest.cc

index 08b18acf01a56c27b35bf7c3d68164d83f4ea61d..2201bf94daa2d9c28c0b83e24b1179b74ac12e6e 100644

--- a/extensions/browser/api/cast_channel/cast_socket_unittest.cc

+++ b/extensions/browser/api/cast_channel/cast_socket_unittest.cc

@@ -92,7 +92,7 @@ class MockTCPSocket : public net::TCPClientSocket {

: TCPClientSocket(net::AddressList(),

nullptr,

- net::NetLog::Source()),

+ net::NetLogSource()),

connect_data_(connect_data),

do_nothing_(false) {}

@@ -100,7 +100,7 @@ class MockTCPSocket : public net::TCPClientSocket {

: TCPClientSocket(net::AddressList(),

nullptr,

- net::NetLog::Source()) {

+ net::NetLogSource()) {

CHECK(do_nothing);

do_nothing_ = do_nothing;

}