extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « extensions/browser/api/display_source/display_source_apitestbase.cc ('k') | extensions/browser/api/dns/dns_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

diff --git a/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc b/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

index 7757575e58755b6787ed500a355a95f5189fcb82..c7e3eb5a0444c54333bd318ee5f7f96a79b5bac8 100644

--- a/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

+++ b/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

@@ -11,6 +11,7 @@

#include "content/public/browser/browser_thread.h"

#include "mojo/public/cpp/bindings/strong_binding.h"

#include "net/base/net_errors.h"

+#include "net/log/net_log_source.h"

using content::BrowserThread;

@@ -75,7 +76,7 @@ void WiFiDisplayMediaServiceImpl::SetDesinationPoint(

rtp_socket_.reset(new net::UDPSocket(net::DatagramSocket::DEFAULT_BIND,

net::RandIntCallback(), nullptr,

- net::NetLog::Source()));

+ net::NetLogSource()));

if (rtp_socket_->Open(end_point.GetFamily()) != net::OK ||

rtp_socket_->Connect(end_point) != net::OK) {

DVLOG(1) << "Could not connect to " << end_point.ToString();