chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/log_private/log_private_api.h ('K') | « chrome/browser/extensions/api/log_private/log_private_api.h ('k') | chrome/browser/extensions/api/platform_keys/verify_trust_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

index a3ee129773327fc5dded4b90171f348e2f5f8320..40af4ea23b8acd172eb22815ebdb9b13b8c3584a 100644

--- a/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc

@@ -34,6 +34,7 @@

#include "extensions/browser/extension_function.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/granted_file_entry.h"

+#include "net/log/net_log_entry.h"

#if defined(OS_CHROMEOS)

#include "chrome/browser/chromeos/system_logs/debug_log_writer.h"

@@ -213,7 +214,7 @@ LogPrivateAPI::GetFactoryInstance() {

return g_factory.Pointer();

}

-void LogPrivateAPI::OnAddEntry(const net::NetLog::Entry& entry) {

+void LogPrivateAPI::OnAddEntry(const net::NetLogEntry& entry) {

// We could receive events on whatever thread they happen to be generated,

// since we are only interested in network events, we should ignore any

// other thread than BrowserThread::IO.