chrome/browser/extensions/api/dial/dial_service.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_service.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/dial/dial_service.cc

diff --git a/chrome/browser/extensions/api/dial/dial_service.cc b/chrome/browser/extensions/api/dial/dial_service.cc

index 06c7d0cc19b7b1e3a827ef8f1506df506f332520..06c7398d3cd5150536db90c917d8c30d343e3c7f 100644

--- a/chrome/browser/extensions/api/dial/dial_service.cc

+++ b/chrome/browser/extensions/api/dial/dial_service.cc

@@ -32,6 +32,7 @@

#include "net/base/network_interfaces.h"

#include "net/http/http_response_headers.h"

#include "net/http/http_util.h"

+#include "net/log/net_log.h"

#include "net/log/net_log_source_type.h"

#include "url/gurl.h"

@@ -164,7 +165,7 @@ DialServiceImpl::DialSocket::~DialSocket() {

bool DialServiceImpl::DialSocket::CreateAndBindSocket(

const IPAddress& bind_ip_address,

net::NetLog* net_log,

- net::NetLog::Source net_log_source) {

+ net::NetLogSource net_log_source) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

DCHECK(!socket_);

DCHECK(bind_ip_address.IsIPv4());