Extracting NetLog inner classes into their own classes.

chrome/browser/extensions/api/log_private/log_private_api.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_LOG_PRIVATE_LOG_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_LOG_PRIVATE_LOG_PRIVATE_API_H_
 
 #include <set>
 #include <string>
 
@@ skipping 72 matching lines @@
   void RegisterTempFileOnFileResourceSequence(
       const std::string& owner_extension_id,
       const base::FilePath& file_path);
 
   // ExtensionRegistryObserver implementation.
   void OnExtensionUnloaded(content::BrowserContext* browser_context,
                            const Extension* extension,
                            UnloadedExtensionInfo::Reason reason) override;
 
   // NetLog::ThreadSafeObserver implementation:
-  void OnAddEntry(const net::NetLog::Entry& entry) override;
+  void OnAddEntry(const net::NetLogEntry& entry) override;

[Devlin, 2016/10/04 15:03:06]

forward declaration needed

[mikecirone, 2016/10/04 17:38:35]

I don't think the forward is needed because the override aspect guarantees that
the class is included/forwarded from the base class's file.

I was finding this forwarding behavior in files I touched, like
fuzzed_socket_factory.h:
https://cs.chromium.org/chromium/src/net/socket/fuzzed_socket_factory.h?gsn=t...

The FuzzedSocketFactory::CreateTransportClientSocket override method has an
AddressList ref and SocketPerformanceWatcher ptr parameters. Both AddressList
and SocketPerformanceWatcher are not included/forwarded in the file, but they
are included/forwarded in the base file, client_socket_factory.h.

[Devlin, 2016/10/04 17:59:22]

Ah, missed that this was an override.  Fair enough. :)

 
   void PostPendingEntries();
   void AddEntriesOnUI(std::unique_ptr<base::ListValue> value);
 
   // Creates a file that will be written to by net::WriteToFileNetLogObserver.
   void CreateTempNetLogFile(const std::string& owner_extension_id,
                             base::ScopedFILE* file);
 
   // Starts observing network events with a new |net_logger| instance.
   void StartObservingNetEvents(IOThread* io_thread, base::ScopedFILE* file);
@@ skipping 94 matching lines @@
   // Callback for DebugLogWriter::StoreLogs() call.
   void OnStoreLogsCompleted(const base::FilePath& log_path, bool succeeded);
   // Callback for LogPrivateAPI::StopAllWatches() call.
   void OnStopAllWatches();
   DISALLOW_COPY_AND_ASSIGN(LogPrivateDumpLogsFunction);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_LOG_PRIVATE_LOG_PRIVATE_API_H_