change SkStreams to work with sk_sp<SkData> instead of SkData*

change SkStreams to work with sk_sp<SkData> instead of SkData*

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333713002

Committed: https://skia.googlesource.com/skia/+/42943c8aa9c611c18ad0f1a30a27669f3d82239c

[reed1, 2016-09-12 13:16:35]

Description was changed from

==========
change SkStreams to work with sk_sp<SkData> instead of SkData*

BUG=skia:
==========

to

==========
change SkStreams to work with sk_sp<SkData> instead of SkData*

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333713002
==========

[reed1, 2016-09-12 13:17:14]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 13:17:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-12 13:17:28]

reed@google.com changed reviewers:
+ msarett@google.com

[commit-bot: I haz the power, 2016-09-12 13:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 13:19:11]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[msarett, 2016-09-12 13:32:07]

Questions about your use of copying streams...

https://codereview.chromium.org/2333713002/diff/1/include/core/SkStream.h
File include/core/SkStream.h (right):

https://codereview.chromium.org/2333713002/diff/1/include/core/SkStream.h#new...
include/core/SkStream.h:317: sk_sp<SkData> makeCopy() const { return fData; }
This is somewhat misleading...

[msarett, 2016-09-12 13:37:30]

On 2016/09/12 13:32:07, msarett wrote:
> Questions about your use of copying streams...
> 
> https://codereview.chromium.org/2333713002/diff/1/include/core/SkStream.h
> File include/core/SkStream.h (right):
> 
>
https://codereview.chromium.org/2333713002/diff/1/include/core/SkStream.h#new...
> include/core/SkStream.h:317: sk_sp<SkData> makeCopy() const { return fData; }
> This is somewhat misleading...

lgtm

[reed1, 2016-09-12 13:59:51]

https://codereview.chromium.org/2333713002/diff/1/include/core/SkStream.h
File include/core/SkStream.h (right):

https://codereview.chromium.org/2333713002/diff/1/include/core/SkStream.h#new...
include/core/SkStream.h:317: sk_sp<SkData> makeCopy() const { return fData; }
On 2016/09/12 13:32:07, msarett wrote:
> This is somewhat misleading...

Done.

[reed1, 2016-09-12 13:59:56]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 14:00:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 14:02:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 14:02:27]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[msarett, 2016-09-12 14:29:45]

lgtm

[reed1, 2016-09-12 15:06:48]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 15:06:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-12 16:16:32]

The CQ bit was checked by reed@google.com

[reed1, 2016-09-12 16:16:33]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/2333713002/#ps100001
(title: "fix xpsdevice")

[commit-bot: I haz the power, 2016-09-12 16:16:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-09-12 16:28:07]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-09-12 16:37:21]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-09-12 16:37:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 17:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 17:09:47]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[reed1, 2016-09-12 17:29:50]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2016-09-12 17:29:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:01:46]

Description was changed from

==========
change SkStreams to work with sk_sp<SkData> instead of SkData*

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333713002
==========

to

==========
change SkStreams to work with sk_sp<SkData> instead of SkData*

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333713002

Committed:
https://skia.googlesource.com/skia/+/42943c8aa9c611c18ad0f1a30a27669f3d82239c
==========

[commit-bot: I haz the power, 2016-09-12 19:01:47]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/42943c8aa9c611c18ad0f1a30a27669f3d82239c