tests/PDFMetadataAttributeTest.cpp - Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFMetadataAttributeTest.cpp

Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData* (Closed)

Patch Set: fix xpsdevice Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFMetadataAttributeTest.cpp

diff --git a/tests/PDFMetadataAttributeTest.cpp b/tests/PDFMetadataAttributeTest.cpp

index 6e7cc248d31e48c580e11a3639f55ec3c77b0862..01351faec31c600cb527b596032a805182a0d47a 100644

--- a/tests/PDFMetadataAttributeTest.cpp

+++ b/tests/PDFMetadataAttributeTest.cpp

@@ -29,7 +29,7 @@ DEF_TEST(SkPDF_Metadata, r) {

metadata, nullptr, false);

doc->beginPage(612.0f, 792.0f);

doc->close();

- sk_sp<SkData> data(pdf.copyToData());

+ sk_sp<SkData> data = pdf.detachAsData();

static const char* expectations[] = {

"/Title (A1)",

"/Author (A2)",

« no previous file with comments | « tests/PDFJpegEmbedTest.cpp ('k') | tests/PDFPrimitivesTest.cpp » ('j') | no next file with comments »