src/xps/SkXPSDevice.cpp - Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/xps/SkXPSDevice.cpp

Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData* (Closed)

Patch Set: fix xpsdevice Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/xps/SkXPSDevice.cpp

diff --git a/src/xps/SkXPSDevice.cpp b/src/xps/SkXPSDevice.cpp

index db152844a148aae2bcce28cddfa668f4a5899057..566651e5d94b758e61fec9b1f90b080a41bb410d 100644

--- a/src/xps/SkXPSDevice.cpp

+++ b/src/xps/SkXPSDevice.cpp

@@ -662,7 +662,7 @@ HRESULT SkXPSDevice::createXpsImageBrush(

HRM(E_FAIL, "Unable to encode bitmap as png.");

}

SkMemoryStream* read = new SkMemoryStream;

- read->setData(write.copyToData())->unref();

+ read->setData(write.detachAsData());

SkTScopedComPtr<IStream> readWrapper;

HRM(SkIStream::CreateFromSkStream(read, true, &readWrapper),

"Could not create stream from png data.");

« no previous file with comments | « src/ports/SkImageGeneratorWIC.cpp ('k') | tests/AnnotationTest.cpp » ('j') | no next file with comments »