tests/PDFJpegEmbedTest.cpp - Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PDFJpegEmbedTest.cpp

Issue 2333713002: change SkStreams to work with sk_sp<SkData> instead of SkData* (Closed)

Patch Set: fix xpsdevice Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/PDFJpegEmbedTest.cpp

diff --git a/tests/PDFJpegEmbedTest.cpp b/tests/PDFJpegEmbedTest.cpp

index 93c204401d1d7aae1b8435ff150e2dfcebd8ca27..2e75c3998af752f61c7037485e3d922f9294751a 100644

--- a/tests/PDFJpegEmbedTest.cpp

+++ b/tests/PDFJpegEmbedTest.cpp

@@ -78,9 +78,8 @@ DEF_TEST(SkPDF_JpegEmbedTest, r) {

canvas->flush();

document->endPage();

document->close();

- sk_sp<SkData> pdfData(pdf.copyToData());

+ sk_sp<SkData> pdfData(pdf.detachAsData());

SkASSERT(pdfData);

- pdf.reset();

REPORTER_ASSERT(r, is_subset_of(mandrillData.get(), pdfData.get()));

@@ -102,9 +101,8 @@ DEF_TEST(SkPDF_JpegEmbedTest, r) {

canvas->flush();

document->endPage();

document->close();

- pdfData.reset(pdf.copyToData());

+ pdfData = pdf.detachAsData();

SkASSERT(pdfData);

- pdf.reset();

REPORTER_ASSERT(r, is_subset_of(mandrillData.get(), pdfData.get()));

« no previous file with comments | « tests/PDFGlyphsToUnicodeTest.cpp ('k') | tests/PDFMetadataAttributeTest.cpp » ('j') | no next file with comments »