Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2333413003: Rename CPDFDoc_Environment to CPDFSDK_Environment (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CPDFDoc_Environment to CPDFSDK_Environment CPDFDoc_Environment does not fit with the general naming scheme of the rest of the files in fpdfsdk. This CL updates the naming to CPDFSDK_Environment to better fit with the surrounding files. Committed: https://pdfium.googlesource.com/pdfium/+/79db609948b01d7a27824b74acc4bd22c8bfd17b

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -869 lines) Patch
M BUILD.gn View 1 4 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/cfx_systemhandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/cpdfdoc_environment.cpp View 1 chunk +0 lines, -214 lines 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
A + fpdfsdk/cpdfsdk_environment.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 18 chunks +19 lines, -19 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_checkbox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_iformfiller.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_radiobutton.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 9 chunks +14 lines, -9 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 15 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 14 chunks +15 lines, -15 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_app.h View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
D fpdfsdk/include/cpdfdoc_environment.h View 1 1 chunk +0 lines, -435 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_annothandlermgr.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_baannothandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_document.h View 4 chunks +4 lines, -4 lines 0 comments Download
A + fpdfsdk/include/cpdfsdk_environment.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_widgethandler.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_xfawidgethandler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/app.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/cjs_context.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/global.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/ijs_runtime.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-13 19:52:25 UTC) #4
Tom Sepez
This makes much more sense now. LGTM. https://codereview.chromium.org/2333413003/diff/1/fpdfsdk/formfiller/cffl_formfiller.h File fpdfsdk/formfiller/cffl_formfiller.h (right): https://codereview.chromium.org/2333413003/diff/1/fpdfsdk/formfiller/cffl_formfiller.h#newcode16 fpdfsdk/formfiller/cffl_formfiller.h:16: class CPDFSDK_Environment; ...
4 years, 3 months ago (2016-09-13 20:55:27 UTC) #7
dsinclair
https://codereview.chromium.org/2333413003/diff/1/fpdfsdk/formfiller/cffl_formfiller.h File fpdfsdk/formfiller/cffl_formfiller.h (right): https://codereview.chromium.org/2333413003/diff/1/fpdfsdk/formfiller/cffl_formfiller.h#newcode16 fpdfsdk/formfiller/cffl_formfiller.h:16: class CPDFSDK_Environment; On 2016/09/13 20:55:26, Tom Sepez wrote: > ...
4 years, 3 months ago (2016-09-14 14:11:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333413003/20001
4 years, 3 months ago (2016-09-14 14:11:47 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 14:27:25 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/79db609948b01d7a27824b74acc4bd22c8bf...

Powered by Google App Engine
This is Rietveld 408576698