[inspector] fixed all shorten-64-to-32 warnings

[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Committed: https://crrev.com/e882623820bd4e49581a3bf61527ebae63c2140c
Cr-Original-Commit-Position: refs/heads/master@{#39426}
Cr-Commit-Position: refs/heads/master@{#39610}

[kozy, 2016-09-12 22:25:52]

Dmitry, please take a look.

[dgozman, 2016-09-12 22:44:25]

lgtm

https://codereview.chromium.org/2332163002/diff/1/src/inspector/String16.cpp
File src/inspector/String16.cpp (right):

https://codereview.chromium.org/2332163002/diff/1/src/inspector/String16.cpp#...
src/inspector/String16.cpp:42: if (ok) *ok = !(*endptr) && result <=
std::numeric_limits<int>::max();
Also check for >= ::min().

https://codereview.chromium.org/2332163002/diff/1/src/inspector/StringUtil.cpp
File src/inspector/StringUtil.cpp (right):

https://codereview.chromium.org/2332163002/diff/1/src/inspector/StringUtil.cp...
src/inspector/StringUtil.cpp:99: if (string.is8Bit())
{}

[kozy, 2016-09-12 23:02:24]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 23:02:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-09-12 23:02:59]

all done.

https://codereview.chromium.org/2332163002/diff/1/src/inspector/String16.cpp
File src/inspector/String16.cpp (right):

https://codereview.chromium.org/2332163002/diff/1/src/inspector/String16.cpp#...
src/inspector/String16.cpp:42: if (ok) *ok = !(*endptr) && result <=
std::numeric_limits<int>::max();
On 2016/09/12 22:44:25, dgozman wrote:
> Also check for >= ::min().

Done.

https://codereview.chromium.org/2332163002/diff/1/src/inspector/StringUtil.cpp
File src/inspector/StringUtil.cpp (right):

https://codereview.chromium.org/2332163002/diff/1/src/inspector/StringUtil.cp...
src/inspector/StringUtil.cpp:99: if (string.is8Bit())
On 2016/09/12 22:44:25, dgozman wrote:
> {}

Done.

[commit-bot: I haz the power, 2016-09-12 23:04:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:04:23]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[kozy, 2016-09-12 23:29:23]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 23:29:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-09-12 23:30:14]

Patchset #4 (id:60001) has been deleted

[kozy, 2016-09-12 23:30:19]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 23:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-09-12 23:31:08]

kozyatinskiy@chromium.org changed reviewers:
+ jochen@chromium.org

[kozy, 2016-09-12 23:31:08]

@jochen, please take a look.
I need owner lgtm for v8.gyp.

[commit-bot: I haz the power, 2016-09-12 23:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 23:57:37]

Dry run: This issue passed the CQ dry run.

[alph, 2016-09-13 00:46:49]

lgtm

https://codereview.chromium.org/2332163002/diff/80001/src/inspector/String16.cpp
File src/inspector/String16.cpp (right):

https://codereview.chromium.org/2332163002/diff/80001/src/inspector/String16....
src/inspector/String16.cpp:377: std::snprintf(buffer, kBufferSize, "%zu",
number);
v8 uses OS::SNPrintF

[kozy, 2016-09-13 01:00:20]

https://codereview.chromium.org/2332163002/diff/80001/src/inspector/String16.cpp
File src/inspector/String16.cpp (right):

https://codereview.chromium.org/2332163002/diff/80001/src/inspector/String16....
src/inspector/String16.cpp:377: std::snprintf(buffer, kBufferSize, "%zu",
number);
On 2016/09/13 00:46:48, alph wrote:
> v8 uses OS::SNPrintF

I'll replace it in follow-up.

[jochen (gone - plz use gerrit), 2016-09-14 08:10:37]

lgtm++ great stuff!

[kozy, 2016-09-14 17:59:35]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-14 17:59:36]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2332163002/#ps80001
(title: "fixed compilation on linux bot")

[commit-bot: I haz the power, 2016-09-14 17:59:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 18:24:26]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-14 18:25:11]

Description was changed from

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}
==========

[commit-bot: I haz the power, 2016-09-14 18:25:12]

Patchset 4 (id:??) landed as
https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}

[Michael Hablich, 2016-09-15 00:35:01]

A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/2339173004/ by hablich@chromium.org.

The reason for reverting is: Blocking V8 roll:
https://codereview.chromium.org/2347463002/

See
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
for compile error..

[alph, 2016-09-15 03:40:04]

On 2016/09/15 00:35:01, Hablich wrote:
> A revert of this CL (patchset #4 id:80001) has been created in
> https://codereview.chromium.org/2339173004/ by mailto:hablich@chromium.org.
> 
> The reason for reverting is: Blocking V8 roll:
> https://codereview.chromium.org/2347463002/
> 
> See
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
> for compile error..

I wonder how come it passed presubmit, but failed on Win bot. Patches collision?

[Michael Achenbach, 2016-09-15 11:22:13]

On 2016/09/15 03:40:04, alph wrote:
> On 2016/09/15 00:35:01, Hablich wrote:
> > A revert of this CL (patchset #4 id:80001) has been created in
> > https://codereview.chromium.org/2339173004/ by mailto:hablich@chromium.org.
> > 
> > The reason for reverting is: Blocking V8 roll:
> > https://codereview.chromium.org/2347463002/
> > 
> > See
> >
>
https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel...
> > for compile error..
> 
> I wonder how come it passed presubmit, but failed on Win bot. Patches
collision?

The chromium win trybot is experimental because it's often too slow. It hardly
ever catches something that no other bot catches. This is an exception.

[kozy, 2016-09-21 21:36:13]

Description was changed from

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}
==========

to

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}
==========

[kozy, 2016-09-21 21:41:23]

Patchset #5 (id:100001) has been deleted

[kozy, 2016-09-21 21:41:31]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:41:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 22:17:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:17:25]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-09-22 00:58:35]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-09-22 00:58:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, jochen@chromium.org, alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2332163002/#ps140001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-22 00:58:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-09-22 00:59:09]

I fixed presented compilation errors on Windows bot. Try to reland it.

[commit-bot: I haz the power, 2016-09-22 01:47:57]

Description was changed from

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}
==========

to

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}
==========

[commit-bot: I haz the power, 2016-09-22 01:47:59]

Committed patchset #6 (id:140001)

[commit-bot: I haz the power, 2016-09-22 01:48:17]

Description was changed from

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Cr-Commit-Position: refs/heads/master@{#39426}
==========

to

==========
[inspector] fixed all shorten-64-to-32 warnings

BUG=chromium:635948
R=dgozman@chromium.org,alph@chromium.org

Committed: https://crrev.com/3d10918d2e1c57d72531c55a956262f5a72fceaa
Committed: https://crrev.com/e882623820bd4e49581a3bf61527ebae63c2140c
Cr-Original-Commit-Position: refs/heads/master@{#39426}
Cr-Commit-Position: refs/heads/master@{#39610}
==========

[commit-bot: I haz the power, 2016-09-22 01:48:18]

Patchset 6 (id:??) landed as
https://crrev.com/e882623820bd4e49581a3bf61527ebae63c2140c
Cr-Commit-Position: refs/heads/master@{#39610}