Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: include/v8-inspector.h

Issue 2332163002: [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/injected-script.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8-inspector.h
diff --git a/include/v8-inspector.h b/include/v8-inspector.h
index aa90de5abb5691dd38daf83e00551491af718aa2..0855ac101b74ef11bf7dccbf13ce02e92e4498d0 100644
--- a/include/v8-inspector.h
+++ b/include/v8-inspector.h
@@ -37,14 +37,14 @@ class V8_EXPORT StringView {
public:
StringView() : m_is8Bit(true), m_length(0), m_characters8(nullptr) {}
- StringView(const uint8_t* characters, unsigned length)
+ StringView(const uint8_t* characters, size_t length)
: m_is8Bit(true), m_length(length), m_characters8(characters) {}
- StringView(const uint16_t* characters, unsigned length)
+ StringView(const uint16_t* characters, size_t length)
: m_is8Bit(false), m_length(length), m_characters16(characters) {}
bool is8Bit() const { return m_is8Bit; }
- unsigned length() const { return m_length; }
+ size_t length() const { return m_length; }
// TODO(dgozman): add DCHECK(m_is8Bit) to accessors once platform can be used
// here.
@@ -53,7 +53,7 @@ class V8_EXPORT StringView {
private:
bool m_is8Bit;
- unsigned m_length;
+ size_t m_length;
union {
const uint8_t* m_characters8;
const uint16_t* m_characters16;
« no previous file with comments | « no previous file | src/inspector/injected-script.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698