Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: src/inspector/v8-stack-trace-impl.cc

Issue 2332163002: [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-runtime-agent-impl.cc ('k') | src/inspector/v8-value-copier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-stack-trace-impl.cc
diff --git a/src/inspector/v8-stack-trace-impl.cc b/src/inspector/v8-stack-trace-impl.cc
index 7af4d99762aafcbddd7fffa2e2fd85219a084c7b..e1eb59ec22f05490de1d23bf6df97d8da71963a2 100644
--- a/src/inspector/v8-stack-trace-impl.cc
+++ b/src/inspector/v8-stack-trace-impl.cc
@@ -46,7 +46,8 @@ void toFramesVector(v8::Local<v8::StackTrace> stackTrace,
size_t maxStackSize, v8::Isolate* isolate) {
DCHECK(isolate->InContext());
int frameCount = stackTrace->GetFrameCount();
- if (frameCount > static_cast<int>(maxStackSize)) frameCount = maxStackSize;
+ if (frameCount > static_cast<int>(maxStackSize))
+ frameCount = static_cast<int>(maxStackSize);
for (int i = 0; i < frameCount; i++) {
v8::Local<v8::StackFrame> stackFrame = stackTrace->GetFrame(i);
frames.push_back(toFrame(stackFrame));
@@ -165,8 +166,8 @@ std::unique_ptr<V8StackTraceImpl> V8StackTraceImpl::capture(
inspector->enabledProfilerAgentForGroup(contextGroupId);
if (profilerAgent) profilerAgent->collectSample();
}
- stackTrace = v8::StackTrace::CurrentStackTrace(isolate, maxStackSize,
- stackTraceOptions);
+ stackTrace = v8::StackTrace::CurrentStackTrace(
+ isolate, static_cast<int>(maxStackSize), stackTraceOptions);
}
return V8StackTraceImpl::create(debugger, contextGroupId, stackTrace,
maxStackSize, description);
« no previous file with comments | « src/inspector/v8-runtime-agent-impl.cc ('k') | src/inspector/v8-value-copier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698