Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: src/inspector/v8-debugger-script.cc

Issue 2332163002: [inspector] fixed all shorten-64-to-32 warnings (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-function-call.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger-script.cc
diff --git a/src/inspector/v8-debugger-script.cc b/src/inspector/v8-debugger-script.cc
index c7e2be4834bebb44cdb2c1f7b4149668b71f3077..485188a48f4eaca4d8ad47268073ef2cb0cc52b1 100644
--- a/src/inspector/v8-debugger-script.cc
+++ b/src/inspector/v8-debugger-script.cc
@@ -11,7 +11,7 @@ namespace v8_inspector {
static const char hexDigits[17] = "0123456789ABCDEF";
-static void appendUnsignedAsHex(unsigned number, String16Builder* destination) {
+static void appendUnsignedAsHex(uint64_t number, String16Builder* destination) {
for (size_t i = 0; i < 8; ++i) {
UChar c = hexDigits[number & 0xF];
destination->append(c);
@@ -75,12 +75,12 @@ static v8::Local<v8::Value> GetChecked(v8::Local<v8::Context> context,
.ToLocalChecked();
}
-static int64_t GetCheckedInt(v8::Local<v8::Context> context,
- v8::Local<v8::Object> object, const char* name) {
- return GetChecked(context, object, name)
- ->ToInteger(context)
- .ToLocalChecked()
- ->Value();
+static int GetCheckedInt(v8::Local<v8::Context> context,
+ v8::Local<v8::Object> object, const char* name) {
+ return static_cast<int>(GetChecked(context, object, name)
+ ->ToInteger(context)
+ .ToLocalChecked()
+ ->Value());
}
V8DebuggerScript::V8DebuggerScript(v8::Local<v8::Context> context,
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.cc ('k') | src/inspector/v8-function-call.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698