services/ui: Use the right type of message-pump in gpu.

services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
Committed: https://crrev.com/4309080a7d997b64c83775822f08b65fdc449a5f
Cr-Commit-Position: refs/heads/master@{#418758}

[sadrul, 2016-09-10 03:21:28]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 03:21:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 04:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 04:42:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2016-09-11 23:52:55]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-11 23:52:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-09-11 23:53:19]

Description was changed from

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process use different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

BUG=643746
==========

to

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process use different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
==========

[sadrul, 2016-09-11 23:55:32]

sadrul@chromium.org changed reviewers:
+ rjkroege@chromium.org

[commit-bot: I haz the power, 2016-09-12 01:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 01:11:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjkroege, 2016-09-12 17:27:05]

Fix the typo in the description? And the test failure seems relevant?

https://codereview.chromium.org/2331453004/diff/20001/services/ui/gpu/gpu_ser...
File services/ui/gpu/gpu_service_internal.cc (right):

https://codereview.chromium.org/2331453004/diff/20001/services/ui/gpu/gpu_ser...
services/ui/gpu/gpu_service_internal.cc:79: #elif defined(OS_LINUX)
So on CrOS-ozone, we will get this one?

https://codereview.chromium.org/2331453004/diff/20001/services/ui/gpu/gpu_ser...
services/ui/gpu/gpu_service_internal.cc:96: #if defined(OS_ANDROID) ||
defined(OS_CHROMEOS)
We should run all of mus at priority DISPLAY. Can you file a bug about this.

[sadrul, 2016-09-13 14:57:14]

Description was changed from

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process use different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
==========

to

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
==========

[sadrul, 2016-09-13 15:05:14]

On 2016/09/12 17:27:05, rjkroege wrote:
> Fix the typo in the description?

Not sure which one you are referring to :)

> And the test failure seems relevant?

The test failures are somewhat unrelated: fixed by
https://codereview.chromium.org/2326203002/

https://codereview.chromium.org/2331453004/diff/20001/services/ui/gpu/gpu_ser...
File services/ui/gpu/gpu_service_internal.cc (right):

https://codereview.chromium.org/2331453004/diff/20001/services/ui/gpu/gpu_ser...
services/ui/gpu/gpu_service_internal.cc:79: #elif defined(OS_LINUX)
On 2016/09/12 17:27:05, rjkroege wrote:
> So on CrOS-ozone, we will get this one?

Correct.

https://codereview.chromium.org/2331453004/diff/20001/services/ui/gpu/gpu_ser...
services/ui/gpu/gpu_service_internal.cc:96: #if defined(OS_ANDROID) ||
defined(OS_CHROMEOS)
On 2016/09/12 17:27:05, rjkroege wrote:
> We should run all of mus at priority DISPLAY. Can you file a bug about this.

Done: crbug.com/646376

[sadrul, 2016-09-13 17:02:47]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 17:03:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 17:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 17:51:10]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-14 04:46:16]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 04:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 04:50:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 04:50:29]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-09-14 15:23:59]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 15:24:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 15:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 15:27:46]

Dry run: This issue passed the CQ dry run.

[rjkroege, 2016-09-15 00:54:10]

lgtm

[sadrul, 2016-09-15 01:32:33]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:14:42]

Description was changed from

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
==========

to

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
==========

[commit-bot: I haz the power, 2016-09-15 02:14:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 02:16:00]

Description was changed from

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746
==========

to

==========
services/ui: Use the right type of message-pump in gpu.

gpu thread in chrome gpu process uses different types of message-pumps in
different platforms (e.g. MessagePumpGpu on Windows etc.) Make sure mus
gpu does the same.

Also, set the gpu thread priority to DISPLAY, on android and cros.

BUG=643746

Committed: https://crrev.com/4309080a7d997b64c83775822f08b65fdc449a5f
Cr-Commit-Position: refs/heads/master@{#418758}
==========

[commit-bot: I haz the power, 2016-09-15 02:16:01]

Patchset 3 (id:??) landed as
https://crrev.com/4309080a7d997b64c83775822f08b65fdc449a5f
Cr-Commit-Position: refs/heads/master@{#418758}