Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2331443003: cc: Split and comment methods for Display vs LayerTreeHostImpl (Closed)

Created:
4 years, 3 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Split and comment methods for Display vs LayerTreeHostImpl This splits the methods on OutputSurface and OutputSurfaceClient based on where they are used, to help with splitting these classes. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/5b20e75e681cb9aaa2d8d9696a9954417c9cc068 Cr-Commit-Position: refs/heads/master@{#418009}

Patch Set 1 #

Patch Set 2 : outputsurfacecomments: few-more-methods #

Patch Set 3 : moremore #

Total comments: 1

Patch Set 4 : outputsurfacecomments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -77 lines) Patch
M cc/output/output_surface.h View 1 2 3 4 chunks +86 lines, -66 lines 0 comments Download
M cc/output/output_surface_client.h View 1 2 3 2 chunks +24 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
danakj
4 years, 3 months ago (2016-09-09 23:49:40 UTC) #3
danakj
Missed a few methods on OutputSurface, updated the patch.
4 years, 3 months ago (2016-09-10 00:13:00 UTC) #7
enne (OOO)
lgtm but https://codereview.chromium.org/2331443003/diff/40001/cc/output/output_surface.h File cc/output/output_surface.h (right): https://codereview.chromium.org/2331443003/diff/40001/cc/output/output_surface.h#newcode125 cc/output/output_surface.h:125: // ============== CONTENT COLLATOR ONLY ========================= Maybe ...
4 years, 3 months ago (2016-09-12 18:25:20 UTC) #12
danakj
Oh ok I said layer tree compositor instead.
4 years, 3 months ago (2016-09-12 18:35:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331443003/60001
4 years, 3 months ago (2016-09-12 18:36:23 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-12 19:46:39 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 19:49:31 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5b20e75e681cb9aaa2d8d9696a9954417c9cc068
Cr-Commit-Position: refs/heads/master@{#418009}

Powered by Google App Engine
This is Rietveld 408576698