|
|
cc: Remove SetMemoryPolicy from OutputSurface and Display.
This method is plumbed through the Display but nothing ever actually
goes there. The only usage of this is:
1) WebView changes the policy based on SyncCompositorMsg_SetMemoryPolicy
but it does so from SynchronousCompositorOutputSurface by calling the
OutputSurfaceClient (LayerTreeHostImpl) directly.
2) CompositorOutputSurface sets a limit when using software compositing.
Instead of 2, pass both gpu and software limits in the LayerTreeSettings,
and have LayerTreeHostImpl use the software limits directly when given
a software output surface. And remove the plumbing through Display and
replace it with a NOTREACHED.
This means we don't have to support the method at all on the
"OutputSurfaceClient" that Display uses, only the one that
LayerTreeHostImpl uses.
Left a comment on OutputSurfaceClient::SetMemoryPolicy() that it is
only used by WebView now. crbug.com/499004 suggests that the WebView
usage could also be replaced with something else. WebView seems to
only be changing the bytes part of the limit, so probably the method
only needs to take that, and I feel like the implementation in
LayerTreeHostImpl could probably be cleaned up some more yet also.
R=enne
TBR=wez
BUG= 499004, 606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/aa5c49175702f57438c939a7e4796ff19de4b681
Cr-Commit-Position: refs/heads/master@{#417778}
Total comments: 6
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+112 lines, -170 lines) |
Patch |
 |
M |
android_webview/browser/surfaces_instance.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
blimp/client/support/compositor/blimp_layer_tree_settings.cc
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/output/output_surface.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/output/output_surface.cc
|
View
|
|
1 chunk |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
cc/output/output_surface_client.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/surfaces/display.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/surfaces/display_client.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/surfaces/display_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface_display_output_surface.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/surfaces/surface_display_output_surface.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_output_surface.h
|
View
|
|
3 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/test/fake_output_surface.cc
|
View
|
|
2 chunks |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
cc/test/test_delegating_output_surface.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/test/test_delegating_output_surface.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.h
|
View
|
1
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl.cc
|
View
|
1
|
3 chunks |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_impl_unittest.cc
|
View
|
|
1 chunk |
+79 lines, -4 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_host_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -79 lines |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_settings.h
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
cc/trees/layer_tree_settings.cc
|
View
|
1
2
3
4
|
2 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
 |
M |
cc/trees/proxy_common_unittest.cc
|
View
|
|
2 chunks |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
cc/trees/proxy_impl.cc
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/renderer/android/synchronous_compositor_output_surface.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/compositor_output_surface.cc
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/renderer/gpu/render_widget_compositor.cc
|
View
|
1
2
3
4
|
2 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
 |
M |
services/ui/surfaces/display_compositor.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
services/ui/surfaces/display_compositor.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
ui/compositor/compositor.cc
|
View
|
1
2
3
4
|
1 chunk |
+3 lines, -7 lines |
0 comments
|
Download
|
Dependent Patchsets:
Total messages: 43 (23 generated)
|