cc: Remove unneeded methods from OutputSurface.

cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made protected.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c54146a5806f7322d06bc5b3079adf1a6fd6b071
Cr-Commit-Position: refs/heads/master@{#418060}

[danakj, 2016-09-10 00:00:00]

Description was changed from

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

R=enne
BUG=606056
==========

to

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-10 00:00:17]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-09-10 00:00:40]

danakj@chromium.org changed reviewers:
+ sky@chromium.org

[danakj, 2016-09-10 00:00:40]

+sky for services/ (will TBR)

[danakj, 2016-09-10 00:00:48]

Description was changed from

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-10 00:01:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:18:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:18:28]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[danakj, 2016-09-10 00:37:12]

Description was changed from

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[enne (OOO), 2016-09-10 00:37:18]

lgtm

[danakj, 2016-09-10 00:37:32]

danakj@chromium.org changed reviewers:
+ boliu@chromium.org, wez@chromium.org

[danakj, 2016-09-10 00:37:32]

+boliu for webview
+wez for blimp

[danakj, 2016-09-10 00:38:05]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:38:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-10 00:38:55]

Description was changed from

==========
cc: Remove forwarding methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-10 00:39:06]

Description was changed from

==========
cc: Remove unneeded methods from OutputSurface.

These three methods only exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

Removes three methods that exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-10 00:39:42]

Description was changed from

==========
cc: Remove unneeded methods from OutputSurface.

Removes three methods that exist to forward to the client, and are called
by subclasses. So remove them (or make private) and have subclasses
call the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made private.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[boliu, 2016-09-10 00:41:10]

lgtm

[commit-bot: I haz the power, 2016-09-10 00:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:52:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-09-10 00:58:06]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-09-10 00:58:24]

https://codereview.chromium.org/2329623003/diff/60001/blimp/client/core/compo...
File blimp/client/core/compositor/delegated_output_surface.h (right):

https://codereview.chromium.org/2329623003/diff/60001/blimp/client/core/compo...
blimp/client/core/compositor/delegated_output_surface.h:52:
base::WeakPtr<BlimpOutputSurfaceClient> blimp_client_;
I renamed this because the base class has a client_ already and this was
shadowing it.

[commit-bot: I haz the power, 2016-09-10 00:58:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 01:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 01:14:39]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Wez, 2016-09-12 00:06:44]

blimp/ LGTM

https://codereview.chromium.org/2329623003/diff/60001/blimp/client/core/compo...
File blimp/client/core/compositor/delegated_output_surface.h (right):

https://codereview.chromium.org/2329623003/diff/60001/blimp/client/core/compo...
blimp/client/core/compositor/delegated_output_surface.h:52:
base::WeakPtr<BlimpOutputSurfaceClient> blimp_client_;
On 2016/09/10 00:58:24, danakj wrote:
> I renamed this because the base class has a client_ already and this was
> shadowing it.

SGTM, although I think we should review this Blimp-specific code, since having
BlimpOutputSurface[Client] not actually be OutputSurface[Client] is super
confusing. CC'ing khushalsagar@ as an FYI on that.

[sky, 2016-09-12 16:54:15]

services LGTM

[danakj, 2016-09-12 18:47:07]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 18:47:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-09-12 18:52:57]

Description was changed from

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made private.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
TBR=sky
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made private.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-12 19:06:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 19:06:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[danakj, 2016-09-12 19:59:41]

Description was changed from

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made private.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made protected.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-09-12 20:00:09]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-09-12 20:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
boliu@chromium.org, wez@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2329623003/#ps120001
(title: "moreanroid")

[commit-bot: I haz the power, 2016-09-12 20:00:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 20:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 20:20:39]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[danakj, 2016-09-12 20:32:21]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-09-12 20:32:21]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org,
boliu@chromium.org, wez@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2329623003/#ps140001
(title: "superandroid")

[commit-bot: I haz the power, 2016-09-12 20:33:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:46:36]

Description was changed from

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made protected.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made protected.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-09-12 21:46:38]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-09-12 21:48:45]

Description was changed from

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made protected.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove unneeded methods from OutputSurface.

Removes two methods that exist to forward to the client, and are
called by subclasses. A third is needed for Bind, but made protected.
The subclasses just call to the client directly.

Also removes SetExternalStencilTest, and moves the state and
implementation of HasExternalStencilTest to the single implementation
that returns true ever.

R=enne
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/c54146a5806f7322d06bc5b3079adf1a6fd6b071
Cr-Commit-Position: refs/heads/master@{#418060}
==========

[commit-bot: I haz the power, 2016-09-12 21:48:46]

Patchset 8 (id:??) landed as
https://crrev.com/c54146a5806f7322d06bc5b3079adf1a6fd6b071
Cr-Commit-Position: refs/heads/master@{#418060}