Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2329803002: Drop FilterEffect::m_absolutePaintRect (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
fs, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), gyuyoung2, jbroman, Justin Novosad, kouhei+svg_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop FilterEffect::m_absolutePaintRect This rect is a remnant of the old ImageBuffer-based implementation of FilterEffect, and is likely doing more harm than good at this point in time. If we want to cache the result of a call to determineAbsolutePaintRect(), that can be done equally well by the client code. Since removing this state removes the last side-effect from the determineAbsolutePaintRect() methods we can mark it and related methods (affectsTransparentPixels) as const. BUG=642035 Committed: https://crrev.com/9c391294d5dc018b76f4bdc36487b16c8c7c4df0 Cr-Commit-Position: refs/heads/master@{#417908}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -62 lines) Patch
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FELighting.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h View 1 3 chunks +4 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp View 3 chunks +2 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/filters/SourceGraphic.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
fs
4 years, 3 months ago (2016-09-10 17:44:34 UTC) #6
pdr.
LGTM https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h File third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h (right): https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h#newcode107 third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h:107: virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect) const; Can you ...
4 years, 3 months ago (2016-09-12 02:46:34 UTC) #7
fs
https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h File third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h (right): https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h#newcode107 third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h:107: virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect) const; On 2016/09/12 at ...
4 years, 3 months ago (2016-09-12 08:55:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329803002/20001
4 years, 3 months ago (2016-09-12 10:20:38 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-12 10:24:34 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 10:28:13 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c391294d5dc018b76f4bdc36487b16c8c7c4df0
Cr-Commit-Position: refs/heads/master@{#417908}

Powered by Google App Engine
This is Rietveld 408576698