Drop FilterEffect::m_absolutePaintRect

Drop FilterEffect::m_absolutePaintRect

This rect is a remnant of the old ImageBuffer-based implementation of
FilterEffect, and is likely doing more harm than good at this point in
time. If we want to cache the result of a call to
determineAbsolutePaintRect(), that can be done equally well by the
client code.

Since removing this state removes the last side-effect from the
determineAbsolutePaintRect() methods we can mark it and related methods
(affectsTransparentPixels) as const.

BUG=642035
Committed: https://crrev.com/9c391294d5dc018b76f4bdc36487b16c8c7c4df0
Cr-Commit-Position: refs/heads/master@{#417908}

[fs, 2016-09-10 15:24:41]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 15:24:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 17:20:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 17:20:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fs, 2016-09-10 17:44:33]

fs@opera.com changed reviewers:
+ pdr@chromium.org

[pdr., 2016-09-12 02:46:34]

LGTM

https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h (right):

https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h:107: virtual
FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect)
const;
Can you document this with a comment?

[fs, 2016-09-12 08:54:42]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 08:55:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-12 08:55:19]

https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h (right):

https://codereview.chromium.org/2329803002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h:107: virtual
FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect)
const;
On 2016/09/12 at 02:46:34, pdr. wrote:
> Can you document this with a comment?

Done.

[commit-bot: I haz the power, 2016-09-12 10:13:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 10:13:36]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-12 10:20:21]

The CQ bit was checked by fs@opera.com

[fs, 2016-09-12 10:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2329803002/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2016-09-12 10:20:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 10:24:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 10:28:12]

Description was changed from

==========
Drop FilterEffect::m_absolutePaintRect

This rect is a remnant of the old ImageBuffer-based implementation of
FilterEffect, and is likely doing more harm than good at this point in
time. If we want to cache the result of a call to
determineAbsolutePaintRect(), that can be done equally well by the
client code.

Since removing this state removes the last side-effect from the
determineAbsolutePaintRect() methods we can mark it and related methods
(affectsTransparentPixels) as const.

BUG=642035
==========

to

==========
Drop FilterEffect::m_absolutePaintRect

This rect is a remnant of the old ImageBuffer-based implementation of
FilterEffect, and is likely doing more harm than good at this point in
time. If we want to cache the result of a call to
determineAbsolutePaintRect(), that can be done equally well by the
client code.

Since removing this state removes the last side-effect from the
determineAbsolutePaintRect() methods we can mark it and related methods
(affectsTransparentPixels) as const.

BUG=642035

Committed: https://crrev.com/9c391294d5dc018b76f4bdc36487b16c8c7c4df0
Cr-Commit-Position: refs/heads/master@{#417908}
==========

[commit-bot: I haz the power, 2016-09-12 10:28:13]

Patchset 2 (id:??) landed as
https://crrev.com/9c391294d5dc018b76f4bdc36487b16c8c7c4df0
Cr-Commit-Position: refs/heads/master@{#417908}