Drop FilterEffect::m_absolutePaintRect

third_party/WebKit/Source/platform/graphics/filters/FilterEffect.h

 /*
  * Copyright (C) 2008 Alex Mathews <possessedpenguinbob@gmail.com>
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 47 matching lines @@
 
     FilterEffectVector& inputEffects() { return m_inputEffects; }
     FilterEffect* inputEffect(unsigned) const;
     unsigned numberOfEffectInputs() const { return m_inputEffects.size(); }
 
     inline bool hasImageFilter() const
     {
         return m_imageFilters[0] || m_imageFilters[1] || m_imageFilters[2] || m_imageFilters[3];
     }
 
-    IntRect absolutePaintRect() const { return m_absolutePaintRect; }
-
     // Clipped primitive subregion in the coordinate space of the target.
     FloatRect absoluteBounds() const;
 
     virtual sk_sp<SkImageFilter> createImageFilter();
     virtual sk_sp<SkImageFilter> createImageFilterWithoutValidation();
 
     // Mapping a rect forwards determines which which destination pixels a
     // given source rect would affect. Mapping a rect backwards determines
     // which pixels from the source rect would be required to fill a given
     // destination rect. Note that these are not necessarily the inverse of
@@ skipping 19 matching lines @@
 
     Filter* getFilter() { return m_filter; }
     const Filter* getFilter() const { return m_filter; }
 
     bool clipsToBounds() const { return m_clipsToBounds; }
     void setClipsToBounds(bool value) { m_clipsToBounds = value; }
 
     ColorSpace operatingColorSpace() const { return m_operatingColorSpace; }
     virtual void setOperatingColorSpace(ColorSpace colorSpace) { m_operatingColorSpace = colorSpace; }
 
-    virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect);
-    virtual bool affectsTransparentPixels() { return false; }
+    virtual FloatRect determineAbsolutePaintRect(const FloatRect& requestedAbsoluteRect) const;

[pdr., 2016/09/12 02:46:34]

Can you document this with a comment?

[fs, 2016/09/12 08:55:19]

Done.

+    virtual bool affectsTransparentPixels() const { return false; }
 
     // Return false if the filter will only operate correctly on valid RGBA values, with
     // alpha in [0,255] and each color component in [0, alpha].
     virtual bool mayProduceInvalidPreMultipliedPixels() { return false; }
 
     SkImageFilter* getImageFilter(ColorSpace, bool requiresPMColorValidation) const;
     void setImageFilter(ColorSpace, bool requiresPMColorValidation, sk_sp<SkImageFilter>);
 
     bool originTainted() const { return m_originTainted; }
     void setOriginTainted() { m_originTainted = true; }
 
     bool inputsTaintOrigin() const;
 
 protected:
     FilterEffect(Filter*);
 
     sk_sp<SkImageFilter> createTransparentBlack() const;
 
     Color adaptColorToOperatingColorSpace(const Color& deviceColor);
 
     SkImageFilter::CropRect getCropRect() const;
 
-    void addAbsolutePaintRect(const FloatRect& absolutePaintRect);
-
 private:
     FilterEffectVector m_inputEffects;
 
-    IntRect m_absolutePaintRect;
-
     Member<Filter> m_filter;
 
     // The following member variables are SVG specific and will move to LayoutSVGResourceFilterPrimitive.
     // See bug https://bugs.webkit.org/show_bug.cgi?id=45614.
 
     // The subregion of a filter primitive according to the SVG Filter specification in local coordinates.
     // This is SVG specific and needs to move to LayoutSVGResourceFilterPrimitive.
     FloatRect m_filterPrimitiveSubregion;
 
     // Should the effect clip to its primitive region, or expand to use the combined region of its inputs.
     bool m_clipsToBounds;
 
     bool m_originTainted;
 
     ColorSpace m_operatingColorSpace;
 
     sk_sp<SkImageFilter> m_imageFilters[4];
 };
 
 } // namespace blink
 
 #endif // FilterEffect_h