third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp - Issue 2329803002: Drop FilterEffect::m_absolutePaintRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

Issue 2329803002: Drop FilterEffect::m_absolutePaintRect (Closed)

Patch Set: Add comment Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.h ('k') | third_party/WebKit/Source/platform/graphics/filters/FELighting.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

index 8f81d740b2e2bc45da13c9d791f72e32ab94cf97..0f2c446470975aba4303d1d3bcc246db1051173a 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEGaussianBlur.cpp

@@ -87,7 +87,7 @@ FloatRect FEGaussianBlur::mapRect(const FloatRect& rect, bool) const

return result;

}

-FloatRect FEGaussianBlur::determineAbsolutePaintRect(const FloatRect& originalRequestedRect)

+FloatRect FEGaussianBlur::determineAbsolutePaintRect(const FloatRect& originalRequestedRect) const

{

FloatRect requestedRect = originalRequestedRect;

if (clipsToBounds())

@@ -97,13 +97,11 @@ FloatRect FEGaussianBlur::determineAbsolutePaintRect(const FloatRect& originalRe

FloatRect inputRect = input->determineAbsolutePaintRect(mapRect(requestedRect, false));

FloatRect outputRect = mapRect(inputRect, true);

outputRect.intersect(requestedRect);

- addAbsolutePaintRect(outputRect);

// Blur needs space for both input and output pixels in the paint area.

// Input is also clipped to subregion.

if (clipsToBounds())

inputRect.intersect(absoluteBounds());

- addAbsolutePaintRect(inputRect);

return outputRect;

}