Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp

Issue 2329803002: Drop FilterEffect::m_absolutePaintRect (Closed)
Patch Set: Add comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
index 05b90282bd219bd33d2d450c475ef7226972ce03..2b663728d28bab97effb40bbd6d24233957db0ea 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
+++ b/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
@@ -113,17 +113,12 @@ bool FEComposite::setK4(float k4)
return true;
}
-FloatRect FEComposite::determineAbsolutePaintRect(const FloatRect& originalRequestedRect)
+FloatRect FEComposite::determineAbsolutePaintRect(const FloatRect& originalRequestedRect) const
{
FloatRect requestedRect = originalRequestedRect;
if (clipsToBounds())
requestedRect.intersect(absoluteBounds());
- // We may be called multiple times if result is used more than once. Return
- // quickly if nothing new is required.
- if (absolutePaintRect().contains(enclosingIntRect(requestedRect)))
- return requestedRect;
-
// No mapPaintRect required for FEComposite.
FloatRect input1Rect = inputEffect(1)->determineAbsolutePaintRect(requestedRect);
FloatRect affectedRect;
@@ -166,7 +161,6 @@ FloatRect FEComposite::determineAbsolutePaintRect(const FloatRect& originalReque
}
affectedRect.intersect(requestedRect);
- addAbsolutePaintRect(affectedRect);
return affectedRect;
}

Powered by Google App Engine
This is Rietveld 408576698