Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2329553002: Cleanup GPU gamut transformation code (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
Reviewers:
msarett, bsalomon, mtklein, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Two changes: 1. Remove special premul handling from gamut xform code Alpha is a constant, so the gamut transformation results remain unchanged (it distributes across the linear matrix multiply). 2. Use SkMatrix44 rather than array of floats Preserves semantic intention, and makes upcoming code (where we transform colors on the CPU by that matrix) simpler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329553002 Committed: https://skia.googlesource.com/skia/+/5192475bd8cb98e8e0c1192ab5ece7b8595701d6

Patch Set 1 #

Patch Set 2 : Switch from float[16] to SkMatrix44 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -53 lines) Patch
M include/gpu/GrColorSpaceXform.h View 1 1 chunk +7 lines, -17 lines 0 comments Download
M src/gpu/GrColorSpaceXform.cpp View 1 2 chunks +4 lines, -7 lines 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLColorSpaceXformHelper.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramDataManager.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramDataManager.cpp View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLShaderBuilder.cpp View 1 chunk +1 line, -14 lines 0 comments Download
M src/image/SkImageShader.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Brian Osman
4 years, 3 months ago (2016-09-09 18:53:29 UTC) #5
Brian Osman
Combined two useful refactorings together.
4 years, 3 months ago (2016-09-09 20:07:17 UTC) #12
bsalomon
lgtm
4 years, 3 months ago (2016-09-12 13:55:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329553002/20001
4 years, 3 months ago (2016-09-12 14:05:16 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 15:50:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5192475bd8cb98e8e0c1192ab5ece7b8595701d6

Powered by Google App Engine
This is Rietveld 408576698