Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2330553003: Gamut transformation of the paint color in Ganesh (Closed)

Created:
4 years, 3 months ago by Brian Osman
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Gamut transformation of the paint color in Ganesh Conversion from sRGB to destination gamut is going to be very common, so I'm caching that xform (if there is one) on the draw context. Results verified in the gamut GM (two more boxes correct). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2330553003 Committed: https://skia.googlesource.com/skia/+/5a7ae7e337a68dc42723fce80752c93b7d26d469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M include/gpu/GrColorSpaceXform.h View 2 chunks +3 lines, -0 lines 0 comments Download
M include/gpu/GrDrawContext.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/gpu/GrColorSpaceXform.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Brian Osman
Matt - just adding you to see what my usage looks like. This is still ...
4 years, 3 months ago (2016-09-09 20:27:25 UTC) #5
bsalomon
lgtm
4 years, 3 months ago (2016-09-12 14:48:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330553003/1
4 years, 3 months ago (2016-09-12 16:14:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 19:07:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5a7ae7e337a68dc42723fce80752c93b7d26d469

Powered by Google App Engine
This is Rietveld 408576698