Add cc::LayerTreeSettings for color correct rendering

Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
TBR=piman

Committed: https://crrev.com/23f6433cbb6eced66e2585c3c6af092776b93f5b
Cr-Commit-Position: refs/heads/master@{#418090}

[ccameron, 2016-09-11 20:34:37]

Description was changed from

==========
cc: Add flag and cc::RendererSettings for color correct rendering

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

BUG=44872
==========

to

==========
cc: Add flag and cc::RendererSettings for color correct rendering

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-11 20:35:31]

Description was changed from

==========
cc: Add flag and cc::RendererSettings for color correct rendering

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Add flag and cc::RendererSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
==========

[ccameron, 2016-09-11 20:35:31]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2016-09-11 20:36:15]

Oops, I shouldn't have put this in content:: originally ...

[ccameron, 2016-09-11 20:36:28]

Description was changed from

==========
cc: Add flag and cc::RendererSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
==========

to

==========
Add cc::RendererSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
==========

[enne (OOO), 2016-09-12 18:33:25]

https://codereview.chromium.org/2328133002/diff/1/cc/output/renderer_settings.h
File cc/output/renderer_settings.h (right):

https://codereview.chromium.org/2328133002/diff/1/cc/output/renderer_settings...
cc/output/renderer_settings.h:40: bool enable_color_correct_rendering;
This should really be in LayerTreeSettings, I think.  RendererSettings is really
going to be just for the display compositor shortly, but all uses haven't been
removed yet.

[ccameron, 2016-09-12 21:20:20]

Description was changed from

==========
Add cc::RendererSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
==========

to

==========
Add cc::RendererSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-12 21:21:40]

https://codereview.chromium.org/2328133002/diff/1/cc/output/renderer_settings.h
File cc/output/renderer_settings.h (right):

https://codereview.chromium.org/2328133002/diff/1/cc/output/renderer_settings...
cc/output/renderer_settings.h:40: bool enable_color_correct_rendering;
On 2016/09/12 18:33:24, enne wrote:
> This should really be in LayerTreeSettings, I think.  RendererSettings is
really
> going to be just for the display compositor shortly, but all uses haven't been
> removed yet.

Sounds good -- moved.

I think that I'll also want it in RendererSettings in the future, too, but then
it'll be LayerTreeSettings for raster, RendererSettings for display.

[enne (OOO), 2016-09-12 21:26:45]

lgtm

On 2016/09/12 at 21:21:40, ccameron wrote:

> I think that I'll also want it in RendererSettings in the future, too, but
then it'll be LayerTreeSettings for raster, RendererSettings for display.

Sounds reasonable.  :)

[ccameron, 2016-09-12 21:42:35]

Description was changed from

==========
Add cc::RendererSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the RendererSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-12 21:43:35]

Description was changed from

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
TBR=piman
==========

[ccameron, 2016-09-12 21:43:59]

Thanks!

Adding TBR piman (out) for content/ and chrome/browser/chromeos/login/ OWNERship

[ccameron, 2016-09-12 21:44:03]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:44:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 22:59:39]

Description was changed from

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
TBR=piman
==========

to

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
TBR=piman
==========

[commit-bot: I haz the power, 2016-09-12 22:59:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 23:00:59]

Description was changed from

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
TBR=piman
==========

to

==========
Add cc::LayerTreeSettings for color correct rendering

Propagate the --enable-color-correct-rendering flag from the browser
to the renderer, and propagate it to the LayerTreeSettings of the
browser and the renderer.

Move the flag from content to cc, because it needs to be set from
content::RenderWidgetCompositor and ui::Compositor (oops).

BUG=44872
TBR=piman

Committed: https://crrev.com/23f6433cbb6eced66e2585c3c6af092776b93f5b
Cr-Commit-Position: refs/heads/master@{#418090}
==========

[commit-bot: I haz the power, 2016-09-12 23:01:00]

Patchset 2 (id:??) landed as
https://crrev.com/23f6433cbb6eced66e2585c3c6af092776b93f5b
Cr-Commit-Position: refs/heads/master@{#418090}