cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

Ensure that this does nothing when --enable-color-correct-rendering is
not specified.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/9a20110f728dac9b1250aee3956ae388741f8905
Cr-Commit-Position: refs/heads/master@{#418362}

[ccameron, 2016-09-12 21:48:01]

Description was changed from

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

BUG=44872
==========

to

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-12 21:49:20]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 21:49:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-09-12 21:50:05]

Description was changed from

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

Ensure that this does nothing when --enable-color-correct-rendering is
not specified.

BUG=44872
==========

[ccameron, 2016-09-12 21:50:05]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org

[ccameron, 2016-09-12 22:01:43]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2016-09-12 22:01:44]

more plumbing of nullptr

[commit-bot: I haz the power, 2016-09-12 22:51:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 22:51:28]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-09-12 22:53:32]

https://codereview.chromium.org/2332143002/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.h (right):

https://codereview.chromium.org/2332143002/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.h:676: // Returns null if
|enable_color_correct_rendering_| is false.
Bikeshedding on readability, but I expect ColorSpaceToSkColorSpace to be a
static function based on its name.  I wouldn't expect something with that name
to magically return nullptr based on settings.

Maybe if you called this GetDestinationColorSpace() so that it seemed less like
a conversion function? Alternatively, moving the conditional out to callsites?

[ccameron, 2016-09-13 01:53:00]

Description was changed from

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

Ensure that this does nothing when --enable-color-correct-rendering is
not specified.

BUG=44872
==========

to

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

Ensure that this does nothing when --enable-color-correct-rendering is
not specified.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ccameron, 2016-09-13 01:54:26]

On 2016/09/12 22:53:32, enne wrote:
>
https://codereview.chromium.org/2332143002/diff/1/cc/resources/resource_provi...
> File cc/resources/resource_provider.h (right):
> 
>
https://codereview.chromium.org/2332143002/diff/1/cc/resources/resource_provi...
> cc/resources/resource_provider.h:676: // Returns null if
> |enable_color_correct_rendering_| is false.
> Bikeshedding on readability, but I expect ColorSpaceToSkColorSpace to be a
> static function based on its name.  I wouldn't expect something with that name
> to magically return nullptr based on settings.
> 
> Maybe if you called this GetDestinationColorSpace() so that it seemed less
like
> a conversion function? Alternatively, moving the conditional out to callsites?

Mmh, good point. All of the callsites pull it from the Resource, so I changed it
to GetResourceSkColorSpace.

[enne (OOO), 2016-09-13 17:30:32]

lgtm

Sorry for the bikeshedding.  <_<

[Justin Novosad, 2016-09-13 17:42:41]

non-owner lgtm
+cc zakerinasab FYI

[ccameron, 2016-09-13 18:36:01]

Thanks!

[ccameron, 2016-09-13 19:49:02]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:49:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:56:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 20:58:32]

Description was changed from

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

Ensure that this does nothing when --enable-color-correct-rendering is
not specified.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Populate SkColorSpace for raster from resource gfx::ColorSpace

Ensure that this does nothing when --enable-color-correct-rendering is
not specified.

BUG=44872
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/9a20110f728dac9b1250aee3956ae388741f8905
Cr-Commit-Position: refs/heads/master@{#418362}
==========

[commit-bot: I haz the power, 2016-09-13 20:58:33]

Patchset 2 (id:??) landed as
https://crrev.com/9a20110f728dac9b1250aee3956ae388741f8905
Cr-Commit-Position: refs/heads/master@{#418362}