cc/output/renderer_settings.h - Issue 2328133002: Add cc::LayerTreeSettings for color correct rendering

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/output/renderer_settings.h

Issue 2328133002: Add cc::LayerTreeSettings for color correct rendering (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « cc/base/switches.cc ('k') | cc/output/renderer_settings.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_OUTPUT_RENDERER_SETTINGS_H_	5 #ifndef CC_OUTPUT_RENDERER_SETTINGS_H_

6 #define CC_OUTPUT_RENDERER_SETTINGS_H_	6 #define CC_OUTPUT_RENDERER_SETTINGS_H_

7	7

8 #include <stddef.h>	8 #include <stddef.h>

9	9

10 #include "cc/base/cc_export.h"	10 #include "cc/base/cc_export.h"

(...skipping 19 matching lines...) Expand all Loading...
30 bool finish_rendering_on_resize;	30 bool finish_rendering_on_resize;

31 bool should_clear_root_render_pass;	31 bool should_clear_root_render_pass;

32 bool disable_display_vsync;	32 bool disable_display_vsync;

33 bool release_overlay_resources_after_gpu_query;	33 bool release_overlay_resources_after_gpu_query;

34 bool gl_composited_texture_quad_border;	34 bool gl_composited_texture_quad_border;

35	35

36 double refresh_rate;	36 double refresh_rate;

37 int highp_threshold_min;	37 int highp_threshold_min;

38 size_t texture_id_allocation_chunk_size;	38 size_t texture_id_allocation_chunk_size;

39 bool use_gpu_memory_buffer_resources;	39 bool use_gpu_memory_buffer_resources;

	40 bool enable_color_correct_rendering;
	enne (OOO) 2016/09/12 18:33:24 This should really be in LayerTreeSettings, I thin This should really be in LayerTreeSettings, I think. RendererSettings is really going to be just for the display compositor shortly, but all uses haven't been removed yet. ccameron 2016/09/12 21:21:40 Sounds good -- moved. I think that I'll also want Show quoted text On 2016/09/12 18:33:24, enne wrote: > This should really be in LayerTreeSettings, I think. RendererSettings is really > going to be just for the display compositor shortly, but all uses haven't been > removed yet. Sounds good -- moved. I think that I'll also want it in RendererSettings in the future, too, but then it'll be LayerTreeSettings for raster, RendererSettings for display.
40 ResourceFormat preferred_tile_format;	41 ResourceFormat preferred_tile_format;

41 BufferToTextureTargetMap buffer_to_texture_target_map;	42 BufferToTextureTargetMap buffer_to_texture_target_map;

42	43

43 void ToProtobuf(proto::RendererSettings* proto) const;	44 void ToProtobuf(proto::RendererSettings* proto) const;

44 void FromProtobuf(const proto::RendererSettings& proto);	45 void FromProtobuf(const proto::RendererSettings& proto);

45	46

46 bool operator==(const RendererSettings& other) const;	47 bool operator==(const RendererSettings& other) const;

47 };	48 };

48	49

49 } // namespace cc	50 } // namespace cc

50	51

51 #endif // CC_OUTPUT_RENDERER_SETTINGS_H_	52 #endif // CC_OUTPUT_RENDERER_SETTINGS_H_

OLD	NEW