Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 232263002: Console logging for rAc developer errors. (Closed)

Created:
6 years, 8 months ago by Evan Stade
Modified:
6 years, 8 months ago
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Console logging for rAc developer errors. Second half of the linked bug. Depends on https://codereview.chromium.org/229723002/ BUG=361216 TBR=michaelbai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263736

Patch Set 1 #

Patch Set 2 : relative #

Patch Set 3 : improvements #

Total comments: 3

Patch Set 4 : merge #

Patch Set 5 : platforms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -14 lines) Patch
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 1 2 3 4 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/content/browser/request_autocomplete_manager_unittest.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 1 2 4 chunks +12 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_delegate.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Evan Stade
+inferno for IPC changes +dbeam for the rest
6 years, 8 months ago (2014-04-09 23:20:26 UTC) #1
Dan Beam
lgtm though if you want to make the error actually show up after the event ...
6 years, 8 months ago (2014-04-10 01:14:51 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-10 01:23:14 UTC) #3
Evan Stade
The CQ bit was unchecked by estade@chromium.org
6 years, 8 months ago (2014-04-10 01:23:17 UTC) #4
Evan Stade
+tsepez for autofill_messages.h
6 years, 8 months ago (2014-04-11 21:28:28 UTC) #5
Evan Stade
also +groby for cocoa +aruslan for android +michaelbai for android webview
6 years, 8 months ago (2014-04-11 21:41:51 UTC) #6
Tom Sepez
Message LGTM.
6 years, 8 months ago (2014-04-11 22:15:08 UTC) #7
groby-ooo-7-16
I oddly feel like I saw this already... either way c/b/ui/cocoa LGTM
6 years, 8 months ago (2014-04-11 22:19:44 UTC) #8
Evan Stade
On 2014/04/11 22:19:44, groby wrote: > I oddly feel like I saw this already... either ...
6 years, 8 months ago (2014-04-11 23:40:41 UTC) #9
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-14 18:00:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/232263002/80001
6 years, 8 months ago (2014-04-14 18:00:28 UTC) #11
aruslan1
lgtm android/
6 years, 8 months ago (2014-04-14 18:01:25 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-14 18:54:06 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=61220
6 years, 8 months ago (2014-04-14 18:54:06 UTC) #14
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 8 months ago (2014-04-14 19:08:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/232263002/80001
6 years, 8 months ago (2014-04-14 19:09:22 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 22:48:49 UTC) #17
Message was sent while issue was closed. 
Change committed as 263736

Powered by Google App Engine
This is Rietveld 408576698