Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3526)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 232263002: Console logging for rAc developer errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: platforms Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 89c71c327c4eaf136d0ce162990abbd861900a0d..aa721a01f69f507aff4ad677c7a78728d1604aa3 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -653,8 +653,10 @@ void AutofillDialogControllerImpl::Show() {
// Fail if the author didn't specify autocomplete types.
if (!has_types) {
- callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
- NULL);
+ callback_.Run(
+ AutofillManagerDelegate::AutocompleteResultErrorUnsupported,
+ base::ASCIIToUTF16("Form is missing autocomplete attributes."),
+ NULL);
delete this;
return;
}
@@ -2180,7 +2182,9 @@ bool AutofillDialogControllerImpl::OnCancel() {
HidePopup();
if (!is_submitting_)
LogOnCancelMetrics();
- callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorCancel, NULL);
+ callback_.Run(AutofillManagerDelegate::AutocompleteResultErrorCancel,
+ base::string16(),
+ NULL);
return true;
}
@@ -3770,6 +3774,7 @@ void AutofillDialogControllerImpl::DoFinishSubmit() {
// Callback should be called as late as possible.
callback_.Run(AutofillManagerDelegate::AutocompleteResultSuccess,
+ base::string16(),
&form_structure_);
data_was_passed_back_ = true;

Powered by Google App Engine
This is Rietveld 408576698