Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: chrome/renderer/autofill/autofill_renderer_browsertest.cc

Issue 232263002: Console logging for rAc developer errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: platforms Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/autofill_renderer_browsertest.cc
diff --git a/chrome/renderer/autofill/autofill_renderer_browsertest.cc b/chrome/renderer/autofill/autofill_renderer_browsertest.cc
index 58c8ad0694b3f8e42e5dda7ed45dbfcd6e178a27..867a0837b29e03a7bfbf5b33b0cd734042682a1d 100644
--- a/chrome/renderer/autofill/autofill_renderer_browsertest.cc
+++ b/chrome/renderer/autofill/autofill_renderer_browsertest.cc
@@ -280,7 +280,9 @@ TEST_F(RequestAutocompleteRendererTest, MainFrameNavigateCancels) {
TEST_F(RequestAutocompleteRendererTest, NoCancelOnSubframeNavigateAfterDone) {
// Pretend that the dialog was cancelled.
autofill_agent_->OnRequestAutocompleteResult(
- WebFormElement::AutocompleteResultErrorCancel, FormData());
+ WebFormElement::AutocompleteResultErrorCancel,
+ base::ASCIIToUTF16("Print me to the console"),
+ FormData());
// Additional navigations should not crash nor send cancels.
NavigateFrame(invoking_frame());
@@ -291,7 +293,9 @@ TEST_F(RequestAutocompleteRendererTest, NoCancelOnSubframeNavigateAfterDone) {
TEST_F(RequestAutocompleteRendererTest, NoCancelOnMainFrameNavigateAfterDone) {
// Pretend that the dialog was cancelled.
autofill_agent_->OnRequestAutocompleteResult(
- WebFormElement::AutocompleteResultErrorCancel, FormData());
+ WebFormElement::AutocompleteResultErrorCancel,
+ base::ASCIIToUTF16("Print me to the console"),
+ FormData());
// Additional navigations should not crash nor send cancels.
NavigateFrame(GetMainFrame());

Powered by Google App Engine
This is Rietveld 408576698