Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: components/autofill/content/browser/request_autocomplete_manager_unittest.cc

Issue 232263002: Console logging for rAc developer errors. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: improvements Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/browser/content_autofill_driver.h" 5 #include "components/autofill/content/browser/content_autofill_driver.h"
6 #include "components/autofill/content/browser/request_autocomplete_manager.h" 6 #include "components/autofill/content/browser/request_autocomplete_manager.h"
7 #include "components/autofill/content/common/autofill_messages.h" 7 #include "components/autofill/content/common/autofill_messages.h"
8 #include "components/autofill/core/browser/test_autofill_manager_delegate.h" 8 #include "components/autofill/core/browser/test_autofill_manager_delegate.h"
9 #include "content/public/test/mock_render_process_host.h" 9 #include "content/public/test/mock_render_process_host.h"
10 #include "content/public/test/test_renderer_host.h" 10 #include "content/public/test/test_renderer_host.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 CustomTestAutofillManagerDelegate() : should_simulate_success_(true) {} 44 CustomTestAutofillManagerDelegate() : should_simulate_success_(true) {}
45 45
46 virtual ~CustomTestAutofillManagerDelegate() {} 46 virtual ~CustomTestAutofillManagerDelegate() {}
47 47
48 virtual void ShowRequestAutocompleteDialog( 48 virtual void ShowRequestAutocompleteDialog(
49 const FormData& form, 49 const FormData& form,
50 const GURL& source_url, 50 const GURL& source_url,
51 const ResultCallback& callback) OVERRIDE { 51 const ResultCallback& callback) OVERRIDE {
52 if (should_simulate_success_) { 52 if (should_simulate_success_) {
53 FormStructure form_structure(form); 53 FormStructure form_structure(form);
54 callback.Run(AutocompleteResultSuccess, &form_structure); 54 callback.Run(AutocompleteResultSuccess,
55 base::string16(),
Dan Beam 2014/04/10 01:14:51 nit: maybe add your fake messages here as well?
56 &form_structure);
55 } else { 57 } else {
56 callback.Run(AutofillManagerDelegate::AutocompleteResultErrorDisabled, 58 callback.Run(AutofillManagerDelegate::AutocompleteResultErrorDisabled,
59 base::string16(),
57 NULL); 60 NULL);
58 } 61 }
59 } 62 }
60 63
61 void set_should_simulate_success(bool should_simulate_success) { 64 void set_should_simulate_success(bool should_simulate_success) {
62 should_simulate_success_ = should_simulate_success; 65 should_simulate_success_ = should_simulate_success;
63 } 66 }
64 67
65 private: 68 private:
66 // Enable testing the path where a callback is called without a 69 // Enable testing the path where a callback is called without a
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // extracts the first |AutofillMsg_RequestAutocompleteResult| message, fills 120 // extracts the first |AutofillMsg_RequestAutocompleteResult| message, fills
118 // the output parameter with the value of the message's parameter, and 121 // the output parameter with the value of the message's parameter, and
119 // clears the queue of sent messages. 122 // clears the queue of sent messages.
120 bool GetAutocompleteResultMessage( 123 bool GetAutocompleteResultMessage(
121 blink::WebFormElement::AutocompleteResult* result) { 124 blink::WebFormElement::AutocompleteResult* result) {
122 const uint32 kMsgID = AutofillMsg_RequestAutocompleteResult::ID; 125 const uint32 kMsgID = AutofillMsg_RequestAutocompleteResult::ID;
123 const IPC::Message* message = 126 const IPC::Message* message =
124 process()->sink().GetFirstMessageMatching(kMsgID); 127 process()->sink().GetFirstMessageMatching(kMsgID);
125 if (!message) 128 if (!message)
126 return false; 129 return false;
127 Tuple2<blink::WebFormElement::AutocompleteResult, FormData> autofill_param; 130 Tuple3<blink::WebFormElement::AutocompleteResult, base::string16, FormData>
131 autofill_param;
128 AutofillMsg_RequestAutocompleteResult::Read(message, &autofill_param); 132 AutofillMsg_RequestAutocompleteResult::Read(message, &autofill_param);
129 *result = autofill_param.a; 133 *result = autofill_param.a;
130 process()->sink().ClearMessages(); 134 process()->sink().ClearMessages();
131 return true; 135 return true;
132 } 136 }
133 137
134 protected: 138 protected:
135 CustomTestAutofillManagerDelegate manager_delegate_; 139 CustomTestAutofillManagerDelegate manager_delegate_;
136 scoped_ptr<TestContentAutofillDriver> driver_; 140 scoped_ptr<TestContentAutofillDriver> driver_;
137 scoped_ptr<RequestAutocompleteManager> request_autocomplete_manager_; 141 scoped_ptr<RequestAutocompleteManager> request_autocomplete_manager_;
(...skipping 19 matching lines...) Expand all
157 TEST_F(RequestAutocompleteManagerTest, 161 TEST_F(RequestAutocompleteManagerTest,
158 OnRequestAutocompleteWithAutofillDisabled) { 162 OnRequestAutocompleteWithAutofillDisabled) {
159 blink::WebFormElement::AutocompleteResult result; 163 blink::WebFormElement::AutocompleteResult result;
160 driver_->mock_autofill_manager()->set_autofill_enabled(false); 164 driver_->mock_autofill_manager()->set_autofill_enabled(false);
161 request_autocomplete_manager_->OnRequestAutocomplete(FormData(), GURL()); 165 request_autocomplete_manager_->OnRequestAutocomplete(FormData(), GURL());
162 EXPECT_TRUE(GetAutocompleteResultMessage(&result)); 166 EXPECT_TRUE(GetAutocompleteResultMessage(&result));
163 EXPECT_EQ(result, blink::WebFormElement::AutocompleteResultSuccess); 167 EXPECT_EQ(result, blink::WebFormElement::AutocompleteResultSuccess);
164 } 168 }
165 169
166 } // namespace autofill 170 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698