Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2321573002: //chrome misc: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, rginda+watch_chromium.org, samuong+watch_chromium.org, tfarina, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//chrome misc: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 TBR=gab@chromium.org, mattm@chromium.org, haven@chromium.org, phajdan.jr@chromium.org, gene@chromium.org, reillyg@chromium.org Committed: https://crrev.com/295d45a0b6618b488ca5690d66c7982198842054 Cr-Commit-Position: refs/heads/master@{#418848}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Fix Win compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -231 lines) Patch
M chrome/installer/mini_installer/decompress_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/archive_patch_helper_unittest.cc View 3 chunks +9 lines, -15 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 13 chunks +20 lines, -14 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 4 chunks +15 lines, -13 lines 0 comments Download
M chrome/installer/util/conditional_work_item_list_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/installer/util/copy_tree_work_item_unittest.cc View 26 chunks +39 lines, -47 lines 0 comments Download
M chrome/installer/util/create_dir_work_item_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/delete_old_versions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/delete_tree_work_item_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/util/duplicate_tree_detector_unittest.cc View 1 chunk +24 lines, -20 lines 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/logging_installer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/lzma_file_allocator_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/lzma_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/installer/util/move_tree_work_item_unittest.cc View 25 chunks +28 lines, -31 lines 0 comments Download
M chrome/installer/util/self_cleaning_temp_dir_unittest.cc View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/installer/util/shell_util_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download
M chrome/test/chromedriver/chrome_launcher_unittest.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/test/chromedriver/session_commands.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/logging/win/test_log_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_filechooser_browsertest.cc View 8 chunks +11 lines, -8 lines 0 comments Download
M chrome/utility/image_writer/image_writer_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/utility/importer/edge_database_reader_unittest_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/utility/importer/safari_importer_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/media_galleries/picasa_album_table_reader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/pmp_column_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/safe_browsing/mac/read_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (13 generated)
vabr (Chromium)
Hello reviewers, This CL is purely a mechanical change (renaming path->GetPath + formatting). In accordance ...
4 years, 3 months ago (2016-09-15 10:46:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321573002/40001
4 years, 3 months ago (2016-09-15 12:55:38 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-15 13:01:22 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/295d45a0b6618b488ca5690d66c7982198842054 Cr-Commit-Position: refs/heads/master@{#418848}
4 years, 3 months ago (2016-09-15 13:04:06 UTC) #17
gab
chrome/installer rs lgtm
4 years, 3 months ago (2016-09-15 13:32:59 UTC) #18
mattm
chrome/utility/safe_browsing lgtm
4 years, 3 months ago (2016-09-15 19:53:47 UTC) #19
Reilly Grant (use Gerrit)
4 years, 3 months ago (2016-09-15 20:00:45 UTC) #20
Message was sent while issue was closed.
//chrome/utility/media_galleries lgtm

Powered by Google App Engine
This is Rietveld 408576698