Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: chrome/installer/util/delete_tree_work_item_unittest.cc

Issue 2321573002: //chrome misc: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Fix Win compilation Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/delete_tree_work_item.h" 5 #include "chrome/installer/util/delete_tree_work_item.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
11 #include "base/files/scoped_temp_dir.h" 11 #include "base/files/scoped_temp_dir.h"
12 #include "base/macros.h" 12 #include "base/macros.h"
13 #include "chrome/installer/util/work_item.h" 13 #include "chrome/installer/util/work_item.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 15
16 namespace { 16 namespace {
17 17
18 constexpr char kTextContent[] = "delete me"; 18 constexpr char kTextContent[] = "delete me";
19 19
20 class DeleteTreeWorkItemTest : public testing::Test { 20 class DeleteTreeWorkItemTest : public testing::Test {
21 protected: 21 protected:
22 DeleteTreeWorkItemTest() = default; 22 DeleteTreeWorkItemTest() = default;
23 23
24 void SetUp() override { 24 void SetUp() override {
25 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 25 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
26 26
27 dir_name_ = temp_dir_.path().Append(FILE_PATH_LITERAL("to_be_deleted")); 27 dir_name_ = temp_dir_.GetPath().Append(FILE_PATH_LITERAL("to_be_deleted"));
28 ASSERT_TRUE(base::CreateDirectory(dir_name_)); 28 ASSERT_TRUE(base::CreateDirectory(dir_name_));
29 ASSERT_TRUE(base::PathExists(dir_name_)); 29 ASSERT_TRUE(base::PathExists(dir_name_));
30 30
31 dir_name_1_ = dir_name_.Append(FILE_PATH_LITERAL("1")); 31 dir_name_1_ = dir_name_.Append(FILE_PATH_LITERAL("1"));
32 ASSERT_TRUE(base::CreateDirectory(dir_name_1_)); 32 ASSERT_TRUE(base::CreateDirectory(dir_name_1_));
33 ASSERT_TRUE(base::PathExists(dir_name_1_)); 33 ASSERT_TRUE(base::PathExists(dir_name_1_));
34 34
35 dir_name_2_ = dir_name_.Append(FILE_PATH_LITERAL("2")); 35 dir_name_2_ = dir_name_.Append(FILE_PATH_LITERAL("2"));
36 ASSERT_TRUE(base::CreateDirectory(dir_name_2_)); 36 ASSERT_TRUE(base::CreateDirectory(dir_name_2_));
37 ASSERT_TRUE(base::PathExists(dir_name_2_)); 37 ASSERT_TRUE(base::PathExists(dir_name_2_));
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 77
78 } // namespace 78 } // namespace
79 79
80 // Delete a tree with rollback enabled and no file in use. Do() should delete 80 // Delete a tree with rollback enabled and no file in use. Do() should delete
81 // everything and Rollback() should bring back everything. 81 // everything and Rollback() should bring back everything.
82 TEST_F(DeleteTreeWorkItemTest, Delete) { 82 TEST_F(DeleteTreeWorkItemTest, Delete) {
83 base::ScopedTempDir temp_dir; 83 base::ScopedTempDir temp_dir;
84 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 84 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
85 85
86 std::unique_ptr<DeleteTreeWorkItem> work_item( 86 std::unique_ptr<DeleteTreeWorkItem> work_item(
87 WorkItem::CreateDeleteTreeWorkItem(dir_name_, temp_dir.path())); 87 WorkItem::CreateDeleteTreeWorkItem(dir_name_, temp_dir.GetPath()));
88 88
89 EXPECT_TRUE(work_item->Do()); 89 EXPECT_TRUE(work_item->Do());
90 ExpectAllFilesDeleted(); 90 ExpectAllFilesDeleted();
91 91
92 work_item->Rollback(); 92 work_item->Rollback();
93 ExpectAllFilesExist(); 93 ExpectAllFilesExist();
94 } 94 }
95 95
96 // Delete a tree with rollback disabled and no file in use. Do() should delete 96 // Delete a tree with rollback disabled and no file in use. Do() should delete
97 // everything and Rollback() shouldn't bring back anything. 97 // everything and Rollback() shouldn't bring back anything.
98 TEST_F(DeleteTreeWorkItemTest, DeleteRollbackDisabled) { 98 TEST_F(DeleteTreeWorkItemTest, DeleteRollbackDisabled) {
99 base::ScopedTempDir temp_dir; 99 base::ScopedTempDir temp_dir;
100 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 100 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
101 101
102 std::unique_ptr<DeleteTreeWorkItem> work_item( 102 std::unique_ptr<DeleteTreeWorkItem> work_item(
103 WorkItem::CreateDeleteTreeWorkItem(dir_name_, temp_dir.path())); 103 WorkItem::CreateDeleteTreeWorkItem(dir_name_, temp_dir.GetPath()));
104 work_item->set_rollback_enabled(false); 104 work_item->set_rollback_enabled(false);
105 105
106 EXPECT_TRUE(work_item->Do()); 106 EXPECT_TRUE(work_item->Do());
107 ExpectAllFilesDeleted(); 107 ExpectAllFilesDeleted();
108 108
109 work_item->Rollback(); 109 work_item->Rollback();
110 ExpectAllFilesDeleted(); 110 ExpectAllFilesDeleted();
111 } 111 }
OLDNEW
« no previous file with comments | « chrome/installer/util/delete_old_versions_unittest.cc ('k') | chrome/installer/util/duplicate_tree_detector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698