misc files R-U: Change ScopedTempDir::path() to GetPath()

misc files R-U: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/a98198273f744d4e045e759734bbaa69962fa94d
Cr-Commit-Position: refs/heads/master@{#421483}

[vabr (Chromium), 2016-09-07 15:33:31]

Description was changed from

==========
misc files R-U: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
==========

to

==========
misc files R-U: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

[vabr (Chromium), 2016-09-15 10:03:18]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-09-15 10:04:30]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:06:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:06:39]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[vabr (Chromium), 2016-09-15 11:21:53]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 11:22:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 11:46:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:46:58]

Dry run: Try jobs failed on following builders:
  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)

[vabr (Chromium), 2016-09-15 14:18:46]

vabr@chromium.org changed reviewers:
+ brettw@chromium.org

[vabr (Chromium), 2016-09-15 14:18:47]

Hi Brett,

Please review the non-trivial change in tools/gn highlighted below, and
rubber-stamp the rest, which is trivial (renaming path->GetPath + formatting).

Cheers,
Vaclav

https://codereview.chromium.org/2317123003/diff/60001/tools/gn/exec_process_u...
File tools/gn/exec_process_unittest.cc (right):

https://codereview.chromium.org/2317123003/diff/60001/tools/gn/exec_process_u...
tools/gn/exec_process_unittest.cc:29: CHECK(temp_dir.CreateUniqueTempDir());
The directory needs to be created before getting its path.

I could not use ASSERT_TRUE in a bool returning function, so I used CHECK.

[vabr (Chromium), 2016-09-15 17:25:20]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 17:26:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 17:55:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 17:55:15]

Dry run: Try jobs failed on following builders:
  win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)

[brettw, 2016-09-27 17:23:11]

lgtm

[vabr (Chromium), 2016-09-28 07:27:41]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-09-28 07:27:42]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2317123003/#ps100001
(title: "Just rebased")

[commit-bot: I haz the power, 2016-09-28 07:27:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 08:45:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-28 08:46:46]

Description was changed from

==========
misc files R-U: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
misc files R-U: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Committed: https://crrev.com/a98198273f744d4e045e759734bbaa69962fa94d
Cr-Commit-Position: refs/heads/master@{#421483}
==========

[commit-bot: I haz the power, 2016-09-28 08:46:48]

Patchset 6 (id:??) landed as
https://crrev.com/a98198273f744d4e045e759734bbaa69962fa94d
Cr-Commit-Position: refs/heads/master@{#421483}