Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2321453002: c/browser, c/common, components S-W: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, eroman, extensions-reviews_chromium.org, grt+watch_chromium.org, kalyank, kinuko+fileapi, Matt Giuca, mmenke, nhiroki, sadrul, sync-reviews_chromium.org, tapted, tfarina, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

c/browser, c/common, components S-W: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 Committed: https://crrev.com/8c498ea4cbdde91a9667486eebf1d9a7b65612d5 Cr-Commit-Position: refs/heads/master@{#418843}

Patch Set 1 #

Patch Set 2 : Add components #

Patch Set 3 : Just rebased #

Patch Set 4 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -194 lines) Patch
M chrome/browser/safe_browsing/download_feedback_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_feedback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 7 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_mac_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/binary_integrity_analyzer_win_unittest.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/signature_evaluator_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 9 chunks +35 lines, -36 lines 0 comments Download
M chrome/browser/shell_integration_win_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/app_list/search/history_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/extension_printer_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac_unittest.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/safe_browsing/binary_feature_extractor_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/service_process_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/prefix_set_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_database_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_local_database_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M components/safe_browsing_db/v4_store_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/keyword_table_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/search_provider_logos/logo_cache_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/session_backend_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/image_capture_device_manager_unittest.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/storage_monitor/media_storage_util_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_chromeos_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/storage_monitor_linux_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M components/storage_monitor/storage_monitor_mac_unittest.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M components/storage_monitor/test_volume_mount_watcher_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/subresource_filter/content/browser/content_ruleset_distributor_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/subresource_filter/core/browser/ruleset_service.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M components/subresource_filter/core/browser/ruleset_service_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/subresource_filter/core/common/test_ruleset_creator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/tracing/browser/trace_config_file_unittest.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M components/update_client/component_patcher_unittest.cc View 1 13 chunks +17 lines, -17 lines 0 comments Download
M components/upload_list/upload_list_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/url_formatter/url_fixer_unittest.cc View 1 6 chunks +22 lines, -17 lines 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/common/web_database_migration_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
vabr (Chromium)
Thanks, Jochen, for your support on this series. This is another purely mechanical CL to ...
4 years, 3 months ago (2016-09-15 10:02:46 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-15 12:33:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321453002/60001
4 years, 3 months ago (2016-09-15 12:36:37 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-15 12:42:21 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 12:44:28 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8c498ea4cbdde91a9667486eebf1d9a7b65612d5
Cr-Commit-Position: refs/heads/master@{#418843}

Powered by Google App Engine
This is Rietveld 408576698