Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2317023003: sync and signin: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
CC:
chromium-reviews, kinuko+fileapi, nhiroki, sync-reviews_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync and signin: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 Committed: https://crrev.com/781998cc3069522b90b25091ed1aff3a0300910c Cr-Commit-Position: refs/heads/master@{#418813}

Patch Set 1 #

Patch Set 2 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -116 lines) Patch
M chrome/browser/sync/test/integration/sync_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_db_migration_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 12 chunks +32 lines, -33 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/browser_sync/browser/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/test_signin_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/webdata/token_service_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/core_impl/attachments/on_disk_attachment_store_unittest.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M components/sync/core_impl/sync_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/directory_backing_store_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/syncable/syncable_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/sync/tools/sync_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
vabr (Chromium)
Hi Jochen, Another purely mechanical CL to stamp, if you could. (There will be likely ...
4 years, 3 months ago (2016-09-15 09:25:59 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-15 09:26:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317023003/20001
4 years, 3 months ago (2016-09-15 09:31:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-15 09:36:34 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 09:38:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/781998cc3069522b90b25091ed1aff3a0300910c
Cr-Commit-Position: refs/heads/master@{#418813}

Powered by Google App Engine
This is Rietveld 408576698