Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: components/tracing/browser/trace_config_file_unittest.cc

Issue 2321453002: c/browser, c/common, components S-W: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Just rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/at_exit.h" 5 #include "base/at_exit.h"
6 #include "base/command_line.h" 6 #include "base/command_line.h"
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "components/tracing/browser/trace_config_file.h" 9 #include "components/tracing/browser/trace_config_file.h"
10 #include "components/tracing/common/tracing_switches.h" 10 #include "components/tracing/common/tracing_switches.h"
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 TEST(TraceConfigFileTest, ValidContent) { 102 TEST(TraceConfigFileTest, ValidContent) {
103 base::ShadowingAtExitManager sem; 103 base::ShadowingAtExitManager sem;
104 std::string content = GetTraceConfigFileContent( 104 std::string content = GetTraceConfigFileContent(
105 kTraceConfig, "10", "trace_result_file.log"); 105 kTraceConfig, "10", "trace_result_file.log");
106 106
107 base::FilePath trace_config_file; 107 base::FilePath trace_config_file;
108 base::ScopedTempDir temp_dir; 108 base::ScopedTempDir temp_dir;
109 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 109 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
110 ASSERT_TRUE( 110 ASSERT_TRUE(
111 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 111 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
112 ASSERT_NE(-1, base::WriteFile( 112 ASSERT_NE(-1, base::WriteFile(
113 trace_config_file, content.c_str(), (int)content.length())); 113 trace_config_file, content.c_str(), (int)content.length()));
114 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 114 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
115 switches::kTraceConfigFile, trace_config_file); 115 switches::kTraceConfigFile, trace_config_file);
116 116
117 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled()); 117 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled());
118 EXPECT_STREQ( 118 EXPECT_STREQ(
119 kTraceConfig, 119 kTraceConfig,
120 TraceConfigFile::GetInstance()->GetTraceConfig().ToString().c_str()); 120 TraceConfigFile::GetInstance()->GetTraceConfig().ToString().c_str());
121 EXPECT_EQ(10, TraceConfigFile::GetInstance()->GetStartupDuration()); 121 EXPECT_EQ(10, TraceConfigFile::GetInstance()->GetStartupDuration());
122 EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("trace_result_file.log")), 122 EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("trace_result_file.log")),
123 TraceConfigFile::GetInstance()->GetResultFile()); 123 TraceConfigFile::GetInstance()->GetResultFile());
124 } 124 }
125 125
126 TEST(TraceConfigFileTest, ValidContentWithOnlyTraceConfig) { 126 TEST(TraceConfigFileTest, ValidContentWithOnlyTraceConfig) {
127 base::ShadowingAtExitManager sem; 127 base::ShadowingAtExitManager sem;
128 std::string content = GetTraceConfigFileContent(kTraceConfig, "", ""); 128 std::string content = GetTraceConfigFileContent(kTraceConfig, "", "");
129 129
130 base::FilePath trace_config_file; 130 base::FilePath trace_config_file;
131 base::ScopedTempDir temp_dir; 131 base::ScopedTempDir temp_dir;
132 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 132 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
133 ASSERT_TRUE( 133 ASSERT_TRUE(
134 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 134 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
135 ASSERT_NE(-1, base::WriteFile( 135 ASSERT_NE(-1, base::WriteFile(
136 trace_config_file, content.c_str(), (int)content.length())); 136 trace_config_file, content.c_str(), (int)content.length()));
137 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 137 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
138 switches::kTraceConfigFile, trace_config_file); 138 switches::kTraceConfigFile, trace_config_file);
139 139
140 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled()); 140 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled());
141 EXPECT_STREQ( 141 EXPECT_STREQ(
142 kTraceConfig, 142 kTraceConfig,
143 TraceConfigFile::GetInstance()->GetTraceConfig().ToString().c_str()); 143 TraceConfigFile::GetInstance()->GetTraceConfig().ToString().c_str());
144 EXPECT_EQ(0, TraceConfigFile::GetInstance()->GetStartupDuration()); 144 EXPECT_EQ(0, TraceConfigFile::GetInstance()->GetStartupDuration());
145 EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("chrometrace.log")), 145 EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("chrometrace.log")),
146 TraceConfigFile::GetInstance()->GetResultFile()); 146 TraceConfigFile::GetInstance()->GetResultFile());
147 } 147 }
148 148
149 TEST(TraceConfigFileTest, ContentWithAbsoluteResultFilePath) { 149 TEST(TraceConfigFileTest, ContentWithAbsoluteResultFilePath) {
150 base::ShadowingAtExitManager sem; 150 base::ShadowingAtExitManager sem;
151 base::ScopedTempDir temp_dir; 151 base::ScopedTempDir temp_dir;
152 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 152 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
153 153
154 const base::FilePath result_file_path = 154 const base::FilePath result_file_path =
155 temp_dir.path().Append(FILE_PATH_LITERAL("trace_result_file.log")); 155 temp_dir.GetPath().Append(FILE_PATH_LITERAL("trace_result_file.log"));
156 ASSERT_TRUE(result_file_path.IsAbsolute()); 156 ASSERT_TRUE(result_file_path.IsAbsolute());
157 157
158 std::string result_file_path_str = result_file_path.AsUTF8Unsafe(); 158 std::string result_file_path_str = result_file_path.AsUTF8Unsafe();
159 auto it = std::find( 159 auto it = std::find(
160 result_file_path_str.begin(), result_file_path_str.end(), '\\'); 160 result_file_path_str.begin(), result_file_path_str.end(), '\\');
161 while (it != result_file_path_str.end()) { 161 while (it != result_file_path_str.end()) {
162 auto it2 = result_file_path_str.insert(it, '\\'); 162 auto it2 = result_file_path_str.insert(it, '\\');
163 it = std::find(it2+2, result_file_path_str.end(), '\\'); 163 it = std::find(it2+2, result_file_path_str.end(), '\\');
164 } 164 }
165 std::string content = GetTraceConfigFileContent( 165 std::string content = GetTraceConfigFileContent(
166 kTraceConfig, "10", result_file_path_str); 166 kTraceConfig, "10", result_file_path_str);
167 167
168 base::FilePath trace_config_file; 168 base::FilePath trace_config_file;
169 ASSERT_TRUE( 169 ASSERT_TRUE(
170 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 170 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
171 ASSERT_NE(-1, base::WriteFile( 171 ASSERT_NE(-1, base::WriteFile(
172 trace_config_file, content.c_str(), (int)content.length())); 172 trace_config_file, content.c_str(), (int)content.length()));
173 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 173 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
174 switches::kTraceConfigFile, trace_config_file); 174 switches::kTraceConfigFile, trace_config_file);
175 175
176 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled()); 176 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled());
177 EXPECT_EQ(result_file_path, TraceConfigFile::GetInstance()->GetResultFile()); 177 EXPECT_EQ(result_file_path, TraceConfigFile::GetInstance()->GetResultFile());
178 } 178 }
179 179
180 TEST(TraceConfigFileTest, ContentWithNegtiveDuration) { 180 TEST(TraceConfigFileTest, ContentWithNegtiveDuration) {
181 base::ShadowingAtExitManager sem; 181 base::ShadowingAtExitManager sem;
182 std::string content = GetTraceConfigFileContent(kTraceConfig, "-1", ""); 182 std::string content = GetTraceConfigFileContent(kTraceConfig, "-1", "");
183 183
184 base::FilePath trace_config_file; 184 base::FilePath trace_config_file;
185 base::ScopedTempDir temp_dir; 185 base::ScopedTempDir temp_dir;
186 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 186 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
187 ASSERT_TRUE( 187 ASSERT_TRUE(
188 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 188 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
189 ASSERT_NE(-1, base::WriteFile( 189 ASSERT_NE(-1, base::WriteFile(
190 trace_config_file, content.c_str(), (int)content.length())); 190 trace_config_file, content.c_str(), (int)content.length()));
191 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 191 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
192 switches::kTraceConfigFile, trace_config_file); 192 switches::kTraceConfigFile, trace_config_file);
193 193
194 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled()); 194 ASSERT_TRUE(TraceConfigFile::GetInstance()->IsEnabled());
195 EXPECT_STREQ( 195 EXPECT_STREQ(
196 kTraceConfig, 196 kTraceConfig,
197 TraceConfigFile::GetInstance()->GetTraceConfig().ToString().c_str()); 197 TraceConfigFile::GetInstance()->GetTraceConfig().ToString().c_str());
198 EXPECT_EQ(0, TraceConfigFile::GetInstance()->GetStartupDuration()); 198 EXPECT_EQ(0, TraceConfigFile::GetInstance()->GetStartupDuration());
199 EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("chrometrace.log")), 199 EXPECT_EQ(base::FilePath(FILE_PATH_LITERAL("chrometrace.log")),
200 TraceConfigFile::GetInstance()->GetResultFile()); 200 TraceConfigFile::GetInstance()->GetResultFile());
201 } 201 }
202 202
203 TEST(TraceConfigFileTest, ContentWithoutTraceConfig) { 203 TEST(TraceConfigFileTest, ContentWithoutTraceConfig) {
204 base::ShadowingAtExitManager sem; 204 base::ShadowingAtExitManager sem;
205 std::string content = GetTraceConfigFileContent( 205 std::string content = GetTraceConfigFileContent(
206 "", "10", "trace_result_file.log"); 206 "", "10", "trace_result_file.log");
207 207
208 base::FilePath trace_config_file; 208 base::FilePath trace_config_file;
209 base::ScopedTempDir temp_dir; 209 base::ScopedTempDir temp_dir;
210 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 210 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
211 ASSERT_TRUE( 211 ASSERT_TRUE(
212 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 212 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
213 ASSERT_NE(-1, base::WriteFile( 213 ASSERT_NE(-1, base::WriteFile(
214 trace_config_file, content.c_str(), (int)content.length())); 214 trace_config_file, content.c_str(), (int)content.length()));
215 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 215 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
216 switches::kTraceConfigFile, trace_config_file); 216 switches::kTraceConfigFile, trace_config_file);
217 217
218 EXPECT_FALSE(TraceConfigFile::GetInstance()->IsEnabled()); 218 EXPECT_FALSE(TraceConfigFile::GetInstance()->IsEnabled());
219 } 219 }
220 220
221 TEST(TraceConfigFileTest, InvalidContent) { 221 TEST(TraceConfigFileTest, InvalidContent) {
222 base::ShadowingAtExitManager sem; 222 base::ShadowingAtExitManager sem;
223 std::string content = "invalid trace config file content"; 223 std::string content = "invalid trace config file content";
224 224
225 base::FilePath trace_config_file; 225 base::FilePath trace_config_file;
226 base::ScopedTempDir temp_dir; 226 base::ScopedTempDir temp_dir;
227 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 227 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
228 ASSERT_TRUE( 228 ASSERT_TRUE(
229 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 229 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
230 ASSERT_NE(-1, base::WriteFile( 230 ASSERT_NE(-1, base::WriteFile(
231 trace_config_file, content.c_str(), (int)content.length())); 231 trace_config_file, content.c_str(), (int)content.length()));
232 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 232 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
233 switches::kTraceConfigFile, trace_config_file); 233 switches::kTraceConfigFile, trace_config_file);
234 234
235 EXPECT_FALSE(TraceConfigFile::GetInstance()->IsEnabled()); 235 EXPECT_FALSE(TraceConfigFile::GetInstance()->IsEnabled());
236 } 236 }
237 237
238 TEST(TraceConfigFileTest, EmptyContent) { 238 TEST(TraceConfigFileTest, EmptyContent) {
239 base::ShadowingAtExitManager sem; 239 base::ShadowingAtExitManager sem;
240 base::FilePath trace_config_file; 240 base::FilePath trace_config_file;
241 base::ScopedTempDir temp_dir; 241 base::ScopedTempDir temp_dir;
242 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 242 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
243 ASSERT_TRUE( 243 ASSERT_TRUE(
244 base::CreateTemporaryFileInDir(temp_dir.path(), &trace_config_file)); 244 base::CreateTemporaryFileInDir(temp_dir.GetPath(), &trace_config_file));
245 base::CommandLine::ForCurrentProcess()->AppendSwitchPath( 245 base::CommandLine::ForCurrentProcess()->AppendSwitchPath(
246 switches::kTraceConfigFile, trace_config_file); 246 switches::kTraceConfigFile, trace_config_file);
247 247
248 EXPECT_FALSE(TraceConfigFile::GetInstance()->IsEnabled()); 248 EXPECT_FALSE(TraceConfigFile::GetInstance()->IsEnabled());
249 } 249 }
250 250
251 } // namespace tracing 251 } // namespace tracing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698