Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2320853005: V8: Prepare switching off gyp in runhooks (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Prepare switching off gyp in runhooks Prepares for https://codereview.chromium.org/2327033002/ A few bots don't/can't use MB - they'll be switched later to GN directly and shouldn't break when switching the defaults. BUG=chromium:474921 TBR=jochen@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/329e32d57bfbbe73c6163f8e2add947239de010b

Patch Set 1 #

Total comments: 1

Messages

Total messages: 11 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2320853005/diff/1/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json File scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json (right): https://codereview.chromium.org/2320853005/diff/1/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json#newcode63 scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json:63: "GYP_CHROMIUM_NO_ACTION": "0", Seems to be the only tester ...
4 years, 3 months ago (2016-09-09 10:33:25 UTC) #3
kjellander_chromium
lgtm
4 years, 3 months ago (2016-09-09 13:04:27 UTC) #6
Michael Achenbach
Landing this TBR as it is a noop before landing https://codereview.chromium.org/2327033002/
4 years, 3 months ago (2016-09-09 13:04:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320853005/1
4 years, 3 months ago (2016-09-09 13:05:07 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 13:08:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/329e32d57bfbbe73c616...

Powered by Google App Engine
This is Rietveld 408576698