Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2320853005: V8: Prepare switching off gyp in runhooks (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import argparse 5 import argparse
6 import contextlib 6 import contextlib
7 import datetime 7 import datetime
8 import difflib 8 import difflib
9 import random 9 import random
10 import re 10 import re
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 if self.c.gyp_env.CC: 267 if self.c.gyp_env.CC:
268 env['CC'] = self.c.gyp_env.CC 268 env['CC'] = self.c.gyp_env.CC
269 if self.c.gyp_env.CXX: 269 if self.c.gyp_env.CXX:
270 env['CXX'] = self.c.gyp_env.CXX 270 env['CXX'] = self.c.gyp_env.CXX
271 if self.c.gyp_env.LINK: 271 if self.c.gyp_env.LINK:
272 env['LINK'] = self.c.gyp_env.LINK 272 env['LINK'] = self.c.gyp_env.LINK
273 if self.c.gyp_env.RANLIB: 273 if self.c.gyp_env.RANLIB:
274 env['RANLIB'] = self.c.gyp_env.RANLIB 274 env['RANLIB'] = self.c.gyp_env.RANLIB
275 if self.m.chromium.c.project_generator.tool != 'gyp': 275 if self.m.chromium.c.project_generator.tool != 'gyp':
276 env['GYP_CHROMIUM_NO_ACTION'] = 1 276 env['GYP_CHROMIUM_NO_ACTION'] = 1
277 else:
278 env['GYP_CHROMIUM_NO_ACTION'] = 0
277 if self.m.chromium.c.gyp_env.GYP_MSVS_VERSION: 279 if self.m.chromium.c.gyp_env.GYP_MSVS_VERSION:
278 env['GYP_MSVS_VERSION'] = self.m.chromium.c.gyp_env.GYP_MSVS_VERSION 280 env['GYP_MSVS_VERSION'] = self.m.chromium.c.gyp_env.GYP_MSVS_VERSION
279 self.m.chromium.runhooks(env=env, **kwargs) 281 self.m.chromium.runhooks(env=env, **kwargs)
280 282
281 @contextlib.contextmanager 283 @contextlib.contextmanager
282 def _temp_dir(self, path): 284 def _temp_dir(self, path):
283 try: 285 try:
284 self.m.file.makedirs('for peeking gn', path) 286 self.m.file.makedirs('for peeking gn', path)
285 yield 287 yield
286 finally: 288 finally:
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 def report_culprits(self, culprit_range): 1235 def report_culprits(self, culprit_range):
1234 assert culprit_range 1236 assert culprit_range
1235 if len(culprit_range) > 1: 1237 if len(culprit_range) > 1:
1236 text = 'Suspecting multiple commits' 1238 text = 'Suspecting multiple commits'
1237 else: 1239 else:
1238 text = 'Suspecting %s' % culprit_range[0][:8] 1240 text = 'Suspecting %s' % culprit_range[0][:8]
1239 1241
1240 step_result = self.m.step(text, cmd=None) 1242 step_result = self.m.step(text, cmd=None)
1241 for culprit in culprit_range: 1243 for culprit in culprit_range:
1242 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit 1244 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698