scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json - Issue 2320853005: V8: Prepare switching off gyp in runhooks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian_nosnap_2.json

Issue 2320853005: V8: Prepare switching off gyp in runhooks (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json ('K') | « scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___1.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json b/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json

index 4b521caff9c4219f522883fcedf905f0152bba85..2d15ad9f3bb3e148aa0969d585be764c292db51d 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json

@@ -60,6 +60,7 @@

"cwd": "[SLAVE_BUILD]/v8",

"env": {

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",

+ "GYP_CHROMIUM_NO_ACTION": "0",

"GYP_CROSSCOMPILE": "1",

"GYP_DEFINES": "target_arch=mips v8_target_arch=mips",

"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian___nosnap___2.json

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Mips___big_endian_nosnap_2.json