Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2320853005: V8: Prepare switching off gyp in runhooks (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___presubmit.json » ('j') | scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/api.py
diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py
index d3d2495e009aac1366a6df276863fa7071d95064..62a3547628f8609c066a2afe485698474a31fb37 100644
--- a/scripts/slave/recipe_modules/v8/api.py
+++ b/scripts/slave/recipe_modules/v8/api.py
@@ -274,6 +274,8 @@ class V8Api(recipe_api.RecipeApi):
env['RANLIB'] = self.c.gyp_env.RANLIB
if self.m.chromium.c.project_generator.tool != 'gyp':
env['GYP_CHROMIUM_NO_ACTION'] = 1
+ else:
+ env['GYP_CHROMIUM_NO_ACTION'] = 0
if self.m.chromium.c.gyp_env.GYP_MSVS_VERSION:
env['GYP_MSVS_VERSION'] = self.m.chromium.c.gyp_env.GYP_MSVS_VERSION
self.m.chromium.runhooks(env=env, **kwargs)
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___presubmit.json » ('j') | scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698