Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2320663002: Fix performance regression in WebGL to 2D canvas draws. (Closed)

Created:
4 years, 3 months ago by Justin Novosad
Modified:
4 years, 3 months ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, haraken, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix performance regression in WebGL to 2D canvas draws. Regression was introduced by this change: https://codereview.chromium.org/2294383002 The change inadvertently modified the steps performed by HTMLCanvasElement::getSourceImageForCanvas by no longer taking advantage of the cached rendering results of the WebGL drawing buffer. A secondary source of regression was that the AccelerationHint was not being propagated correctly. BUG=644401 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TEST=blink_perf.canvas / draw-static-webgl-to-hw-accelerated-canvas-2d Committed: https://crrev.com/980562f70d53ff313d4f5cd885c70248d3dd902a Cr-Commit-Position: refs/heads/master@{#417029}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
Justin Novosad
@kbr: PTAL
4 years, 3 months ago (2016-09-07 14:49:19 UTC) #3
Ken Russell (switch to Gerrit)
lgtm Good to know there is a perf test covering this code path.
4 years, 3 months ago (2016-09-07 17:49:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320663002/1
4 years, 3 months ago (2016-09-07 18:08:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 19:35:38 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:38:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/980562f70d53ff313d4f5cd885c70248d3dd902a
Cr-Commit-Position: refs/heads/master@{#417029}

Powered by Google App Engine
This is Rietveld 408576698